-
Notifications
You must be signed in to change notification settings - Fork 55
fix: handle empty icon name in notification item #1193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1. Modified DciIcon name property to use a fallback value when iconName is empty 2. Added default icon "application-x-desktop" to prevent missing icon display 3. Ensures notifications always show an appropriate icon even when none is specified fix: 处理通知项中图标名称为空的情况 1. 修改 DciIcon 的 name 属性,在 iconName 为空时使用回退值 2. 添加默认图标 "application-x-desktop" 防止图标缺失显示 3. 确保即使未指定图标时通知也能显示适当的图标 pms: BUG-311315
deepin pr auto review关键摘要:
是否建议立即修改:
|
Reviewer's GuideAdds conditional logic to DciIcon name binding, defaulting to “application-x-desktop” when iconName is empty to ensure notifications always display an icon. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @18202781743 - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
is empty
display
is specified
fix: 处理通知项中图标名称为空的情况
pms: BUG-311315
Summary by Sourcery
Bug Fixes: