fix: update connection for active window icon change

[BLumia]

当前有多个源头触发 iconChanged: AppItem::currentActiveWindowChanged 和 DesktopfileAbstractParser::iconChanged。这会导致 iconName 的 loop binding。此修改将其中一个调整为 QueuedConnection 来避免循环绑定。

（注：是在尝试排查和修复其他 bug 时进行的修复，但发现这个修正并没有解决原本目标要解决的bug，只解决了这个警告）

Summary by Sourcery

Bug Fixes:

• Change the connection for AbstractWindow::iconChanged in AppItem to a queued connection to prevent loop bindings

[sourcery-ai]

Reviewer's Guide

This patch resolves a recursive iconChanged binding by converting the direct signal-slot connection on AbstractWindow to a queued connection, preventing warning loops.

Sequence diagram for iconChanged signal-slot connection update

sequenceDiagram
    participant AppItem
    participant AbstractWindow
    note over AppItem,AbstractWindow: Before: Direct connection (default)
    AppItem->>AbstractWindow: connect(iconChanged, iconChanged)
    AbstractWindow-->>AppItem: iconChanged (direct)
    note over AppItem,AbstractWindow: After: Queued connection
    AppItem->>AbstractWindow: connect(iconChanged, iconChanged, QueuedConnection)
    AbstractWindow--x AppItem: iconChanged (queued)

Loading

Class diagram for AppItem and AbstractWindow signal-slot relationship

classDiagram
    class AppItem {
        +updateCurrentActiveWindow(window)
        +iconChanged()
        +currentActiveWindowChanged()
        -m_currentActiveWindow
    }
    class AbstractWindow {
        +iconChanged()
    }
    AppItem o-- AbstractWindow : m_currentActiveWindow
    AppItem ..> AbstractWindow : connect iconChanged (now QueuedConnection)

Loading

File-Level Changes

Change	Details	Files
Convert iconChanged connection to queued to break loop binding	Replaced direct connect call with Qt::QueuedConnection Retained signal and slot parameters correctly	panels/dock/taskmanager/appitem.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[deepin-ci-robot]

deepin pr auto review

关键摘要:

• 在connect函数中添加了Qt::QueuedConnection标志，这可能会影响信号和槽的执行顺序，需要确认这是否符合预期行为。

是否建议立即修改:

• 是，需要确认Qt::QueuedConnection的使用是否符合设计意图，并确保不会引入任何潜在的问题。如果这个标志的使用是必要的，应该添加相应的注释说明其目的。如果不需要，应该将其移除。

[sourcery-ai]

Hey @BLumia - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, BLumia

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment