-
Notifications
You must be signed in to change notification settings - Fork 55
fix: incorrect icon and copywriting for Mic ON/OFF OSD #1199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
修正麦克风开启/关闭 OSD 提示的图标和文案不正确的问题 PMS: BUG-323793 BUG-323797 Log:
Reviewer's GuideThis PR corrects the microphone OSD by swapping icons and labels in QML and adding corresponding translation entries across all TS files, while standardizing TS file headers. Class diagram for OSD ListElement changes (Mic ON/OFF)classDiagram
class AppletItem {
ListElement[] osdElements
}
class ListElement {
string type
string iconName
string text
}
AppletItem "1" *-- "*" ListElement
%% Highlight the updated elements
class AudioMicMuteOn {
type = "AudioMicMuteOn"
iconName = "osd_mic_off" %% changed from osd_mic_on
text = "Microphone off" %% changed from "Mute on"
}
class AudioMicMuteOff {
type = "AudioMicMuteOff"
iconName = "osd_mic_on" %% changed from osd_mic_off
text = "Microphone on" %% changed from "Mute off"
}
AppletItem -- AudioMicMuteOn
AppletItem -- AudioMicMuteOff
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review代码审查意见:
总体来说,这次提交的改动是合理的,但是需要确保所有相关的翻译都已经完成,并且文件格式的一致性不会受到影响。同时,建议在未来的提交中保持代码风格的一致性,并定期进行性能和安全性测试。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @BLumia - I've reviewed your changes - here's some feedback:
- Verify that the QML icon assets
osd_mic_onandosd_mic_offexist in the assets folder and render correctly with the updated entries. - Consider renaming the QML
typefields (currentlyAudioMicMuteOn/AudioMicMuteOff) to something likeMicrophoneOff/MicrophoneOnto more clearly reflect the new semantics.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Verify that the QML icon assets `osd_mic_on` and `osd_mic_off` exist in the assets folder and render correctly with the updated entries.
- Consider renaming the QML `type` fields (currently `AudioMicMuteOn`/`AudioMicMuteOff`) to something like `MicrophoneOff`/`MicrophoneOn` to more clearly reflect the new semantics.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
@BLumia: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, yixinshark The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
修正麦克风开启/关闭 OSD 提示的图标和文案不正确的问题
Summary by Sourcery
Fix the microphone OSD display by swapping the mute icons and updating labels from “Mute on/off” to “Microphone off/on” and synchronize translation files accordingly.
Bug Fixes:
Enhancements: