Skip to content

fix: handle NoDisplay apps in notification settings #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
18202781743 merged 1 commit into from
Aug 7, 2025
Merged

fix: handle NoDisplay apps in notification settings #1215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions panels/notification/server/notificationmanager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,8 @@ uint NotificationManager::Notify(const QString &appName, uint replacesId, const
auto tsAppName = m_setting->appValue(appId, NotificationSetting::AppName).toString();
if (tsAppName.isEmpty()) {
tsAppName = appName;
} else {
qCDebug(notifyLog) << "AppName is translated from AM, which appId is:" << appId;
}

QString strBody = body;
Expand Down
3 changes: 0 additions & 3 deletions panels/notification/server/notificationsetting.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,9 +247,6 @@ QList<NotificationSetting::AppItem> NotificationSetting::appItemsImpl() const
apps.reserve(m_appAccessor->rowCount());
for (int i = 0; i < m_appAccessor->rowCount(); i++) {
const auto index = m_appAccessor->index(i, 0);
const auto nodisplay = m_appAccessor->data(index, NoDisplayRole).toBool();
if (nodisplay)
continue;

const auto desktopId = m_appAccessor->data(index, DesktopIdRole).toString();
const auto icon = m_appAccessor->data(index, IconNameRole).toString();
Expand Down