-
Notifications
You must be signed in to change notification settings - Fork 55
chore: add ar, de, lo, sq to DDEShellPackageMacros.cmake #1220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
添加 ar, de, lo, sq 四个语言到 DDEShellPackageMacros 配置文件中 Log:
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdated DDEShellPackageMacros.cmake to register four additional translation files (Arabic, German, Lao, Albanian) in the package translation routine by appending their .ts paths to the TRANSLATION_FILES list. Class diagram for updated translation file registration in DDEShellPackageMacros.cmakeclassDiagram
class ds_handle_package_translation {
+TRANSLATION_FILES: list
+register_translation_files()
}
ds_handle_package_translation : +ar (.ts)
ds_handle_package_translation : +de (.ts)
ds_handle_package_translation : +lo (.ts)
ds_handle_package_translation : +sq (.ts)
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review代码审查意见:
改进建议:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @BLumia - I've reviewed your changes - here's some feedback:
- Ensure the new .ts translation files for ar, de, lo, and sq are actually added to the translations directory and committed.
- Consider extracting this hard-coded list of language codes into a sorted variable or loop to simplify maintenance and avoid manual ordering mistakes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Ensure the new .ts translation files for ar, de, lo, and sq are actually added to the translations directory and committed.
- Consider extracting this hard-coded list of language codes into a sorted variable or loop to simplify maintenance and avoid manual ordering mistakes.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
添加 ar, de, lo, sq 四个语言到 DDEShellPackageMacros 配置文件中
Summary by Sourcery
Enhancements: