Skip to content

fix: improve notification close button hover detection #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
18202781743 merged 1 commit into from
Sep 23, 2025
Merged

fix: improve notification close button hover detection #1262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions panels/notification/plugin/NotifyItemContent.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ NotifyItem {
id: root
implicitWidth: impl.implicitWidth
implicitHeight: impl.implicitHeight
property bool closeVisible: activeFocus
property bool closeVisible: activeFocus || impl.hovered
property int miniContentHeight: NotifyStyle.contentItem.miniHeight
property bool enableDismissed: true

Expand Down Expand Up @@ -47,8 +47,8 @@ NotifyItem {
}

// placeHolder to receive MouseEvent
FocusScope {
focus: true
Control {
id: closePlaceHolder
anchors {
top: parent.top
topMargin: -height / 2
Expand All @@ -60,7 +60,7 @@ NotifyItem {

Loader {
focus: true
active: !(root.strongInteractive && root.actions.length > 0) && (root.closeVisible || activeFocus)
active: !(root.strongInteractive && root.actions.length > 0) && (root.closeVisible || closePlaceHolder.hovered || activeFocus)
sourceComponent: SettingActionButton {
id: closeBtn
objectName: "closeNotify-" + root.appName
Expand Down