Skip to content

feat: add button text labels for accessibility #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wjyrich merged 1 commit into from
Sep 23, 2025
Merged

feat: add button text labels for accessibility #1265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions panels/notification/center/GroupNotify.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,17 +33,19 @@ NotifyItem {
Layout.preferredHeight: 1
}

SettingActionButton {
AnimationSettingButton {
Layout.alignment: Qt.AlignRight
icon.name: "fold"
text: qsTr("Fold")
onClicked: {
console.log("collapse")
root.collapse()
}
}
SettingActionButton {
AnimationSettingButton {
Layout.alignment: Qt.AlignRight
icon.name: "more"
text: qsTr("More")
onClicked: function () {
console.log("group setting", root.appName)
let pos = mapToItem(root, Qt.point(width / 2, height))
Expand Down
6 changes: 4 additions & 2 deletions panels/notification/center/NotifyHeader.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,23 +28,25 @@ FocusScope {
Layout.preferredHeight: 1
}

SettingActionButton {
AnimationSettingButton {
objectName: "collapse"
focus: true
visible: !notifyModel.collapse
Layout.alignment: Qt.AlignRight
icon.name: "fold"
text: qsTr("Fold")
onClicked: function () {
console.log("Collapse all notify")
notifyModel.collapseAllApp()
}
}

SettingActionButton {
AnimationSettingButton {
objectName: "more"
focus: true
Layout.alignment: Qt.AlignRight
icon.name: "more"
text: qsTr("More")
onClicked: function () {
console.log("Notify setting")
NotifyAccessor.openNotificationSetting()
Expand Down
16 changes: 16 additions & 0 deletions panels/notification/center/translations/org.deepin.ds.notificationcenter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,14 @@
<source>Clear All</source>
<translation type="unfinished"></translation>
</message>
<message>
<source>Fold</source>
<translation type="unfinished"></translation>
</message>
<message>
<source>More</source>
<translation type="unfinished"></translation>
</message>
</context>
<context>
<name>NotifyCenter</name>
Expand All @@ -25,6 +33,14 @@
<source>Clear All</source>
<translation type="unfinished"></translation>
</message>
<message>
<source>Fold</source>
<translation type="unfinished"></translation>
</message>
<message>
<source>More</source>
<translation type="unfinished"></translation>
</message>
</context>
<context>
<name>NotifySetting</name>
Expand Down
24 changes: 21 additions & 3 deletions panels/notification/center/translations/org.deepin.ds.notificationcenter_ar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,26 @@
<?xml version="1.0" ?><!DOCTYPE TS><TS version="2.1" language="ar">
<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE TS>
<TS version="2.1" language="ar">
<context>
<name>GroupNotify</name>
<message>
<source>Clear All</source>
<translation>مسح الكل</translation>
</message>
<message>
<source>Fold</source>
<translation type="unfinished"></translation>
</message>
<message>
<source>More</source>
<translation type="unfinished"></translation>
</message>
</context>
<context>
<name>NotifyCenter</name>
<message>
<source>No recent notifications</source>
<translation type="unfinished"/>
<translation type="unfinished"></translation>
</message>
</context>
<context>
Expand All @@ -23,6 +33,14 @@
<source>Clear All</source>
<translation>مسح الكل</translation>
</message>
<message>
<source>Fold</source>
<translation type="unfinished"></translation>
</message>
<message>
<source>More</source>
<translation type="unfinished"></translation>
</message>
</context>
<context>
<name>NotifySetting</name>
Expand All @@ -46,4 +64,4 @@
<translation>قبل دقيقة واحدة</translation>
</message>
</context>
</TS>
</TS>
24 changes: 21 additions & 3 deletions panels/notification/center/translations/org.deepin.ds.notificationcenter_az.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,26 @@
<?xml version="1.0" ?><!DOCTYPE TS><TS version="2.1" language="az">
<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE TS>
<TS version="2.1" language="az">
<context>
<name>GroupNotify</name>
<message>
<source>Clear All</source>
<translation>مسح الكل</translation>
</message>
<message>
<source>Fold</source>
<translation type="unfinished"></translation>
</message>
<message>
<source>More</source>
<translation type="unfinished"></translation>
</message>
</context>
<context>
<name>NotifyCenter</name>
<message>
<source>No recent notifications</source>
<translation type="unfinished"/>
<translation type="unfinished"></translation>
</message>
</context>
<context>
Expand All @@ -23,6 +33,14 @@
<source>Clear All</source>
<translation>مسح الكل</translation>
</message>
<message>
<source>Fold</source>
<translation type="unfinished"></translation>
</message>
<message>
<source>More</source>
<translation type="unfinished"></translation>
</message>
</context>
<context>
<name>NotifySetting</name>
Expand All @@ -46,4 +64,4 @@
<translation>الآن</translation>
</message>
</context>
</TS>
</TS>
16 changes: 16 additions & 0 deletions panels/notification/center/translations/org.deepin.ds.notificationcenter_bo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,14 @@
<source>Clear All</source>
<translation type="unfinished"></translation>
</message>
<message>
<source>Fold</source>
<translation type="unfinished"></translation>
</message>
<message>
<source>More</source>
<translation type="unfinished"></translation>
</message>
</context>
<context>
<name>NotifyCenter</name>
Expand All @@ -25,6 +33,14 @@
<source>Clear All</source>
<translation type="unfinished"></translation>
</message>
<message>
<source>Fold</source>
<translation type="unfinished"></translation>
</message>
<message>
<source>More</source>
<translation type="unfinished"></translation>
</message>
</context>
<context>
<name>NotifySetting</name>
Expand Down
22 changes: 20 additions & 2 deletions panels/notification/center/translations/org.deepin.ds.notificationcenter_ca.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,20 @@
<?xml version="1.0" ?><!DOCTYPE TS><TS version="2.1" language="ca">
<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE TS>
<TS version="2.1" language="ca">
<context>
<name>GroupNotify</name>
<message>
<source>Clear All</source>
<translation>Neteja-ho tot</translation>
</message>
<message>
<source>Fold</source>
<translation type="unfinished"></translation>
</message>
<message>
<source>More</source>
<translation type="unfinished"></translation>
</message>
</context>
<context>
<name>NotifyCenter</name>
Expand All @@ -23,6 +33,14 @@
<source>Clear All</source>
<translation>Neteja-ho tot</translation>
</message>
<message>
<source>Fold</source>
<translation type="unfinished"></translation>
</message>
<message>
<source>More</source>
<translation type="unfinished"></translation>
</message>
</context>
<context>
<name>NotifySetting</name>
Expand All @@ -46,4 +64,4 @@
<translation>Ara mateix</translation>
</message>
</context>
</TS>
</TS>
24 changes: 21 additions & 3 deletions panels/notification/center/translations/org.deepin.ds.notificationcenter_de.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,26 @@
<?xml version="1.0" ?><!DOCTYPE TS><TS version="2.1" language="de">
<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE TS>
<TS version="2.1" language="de">
<context>
<name>GroupNotify</name>
<message>
<source>Clear All</source>
<translation>Alles leeren</translation>
</message>
<message>
<source>Fold</source>
<translation type="unfinished"></translation>
</message>
<message>
<source>More</source>
<translation type="unfinished"></translation>
</message>
</context>
<context>
<name>NotifyCenter</name>
<message>
<source>No recent notifications</source>
<translation type="unfinished"/>
<translation type="unfinished"></translation>
</message>
</context>
<context>
Expand All @@ -23,6 +33,14 @@
<source>Clear All</source>
<translation>Alles leeren</translation>
</message>
<message>
<source>Fold</source>
<translation type="unfinished"></translation>
</message>
<message>
<source>More</source>
<translation type="unfinished"></translation>
</message>
</context>
<context>
<name>NotifySetting</name>
Expand All @@ -46,4 +64,4 @@
<translation>Gerade eben</translation>
</message>
</context>
</TS>
</TS>
22 changes: 20 additions & 2 deletions panels/notification/center/translations/org.deepin.ds.notificationcenter_es.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,20 @@
<?xml version="1.0" ?><!DOCTYPE TS><TS version="2.1" language="es">
<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE TS>
<TS version="2.1" language="es">
<context>
<name>GroupNotify</name>
<message>
<source>Clear All</source>
<translation>Limpiar todo</translation>
</message>
<message>
<source>Fold</source>
<translation type="unfinished"></translation>
</message>
<message>
<source>More</source>
<translation type="unfinished"></translation>
</message>
</context>
<context>
<name>NotifyCenter</name>
Expand All @@ -23,6 +33,14 @@
<source>Clear All</source>
<translation>Limpiar todo</translation>
</message>
<message>
<source>Fold</source>
<translation type="unfinished"></translation>
</message>
<message>
<source>More</source>
<translation type="unfinished"></translation>
</message>
</context>
<context>
<name>NotifySetting</name>
Expand All @@ -46,4 +64,4 @@
<translation>Ahora mismo</translation>
</message>
</context>
</TS>
</TS>
22 changes: 20 additions & 2 deletions panels/notification/center/translations/org.deepin.ds.notificationcenter_fi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,20 @@
<?xml version="1.0" ?><!DOCTYPE TS><TS version="2.1" language="fi">
<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE TS>
<TS version="2.1" language="fi">
<context>
<name>GroupNotify</name>
<message>
<source>Clear All</source>
<translation>Tyhjennä kaikki</translation>
</message>
<message>
<source>Fold</source>
<translation type="unfinished"></translation>
</message>
<message>
<source>More</source>
<translation type="unfinished"></translation>
</message>
</context>
<context>
<name>NotifyCenter</name>
Expand All @@ -23,6 +33,14 @@
<source>Clear All</source>
<translation>Tyhjennä kaikki</translation>
</message>
<message>
<source>Fold</source>
<translation type="unfinished"></translation>
</message>
<message>
<source>More</source>
<translation type="unfinished"></translation>
</message>
</context>
<context>
<name>NotifySetting</name>
Expand All @@ -46,4 +64,4 @@
<translation>Juuri nyt</translation>
</message>
</context>
</TS>
</TS>
Loading