-
Notifications
You must be signed in to change notification settings - Fork 55
fix: adjust notification center window positioning #1267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixed notification center window positioning by adding top margin to match the left/right margins. Previously the window was flush with the top edge while having side margins, creating inconsistent spacing. Now the top margin uses the same contentPadding value as the sides for consistent visual alignment. Influence: 1. Verify notification center appears with equal spacing on all sides 2. Test that window positioning remains correct when contentPadding changes 3. Check that notifications display properly within the adjusted bounds fix: 调整通知中心窗口位置 修复通知中心窗口位置问题,通过添加顶部边距使其与左右边距保持一致。之前窗 口顶部边缘没有边距而两侧有边距,导致间距不一致。现在顶部边距使用与两侧相 同的contentPadding值,实现一致的视觉对齐。 Influence: 1. 验证通知中心在所有边距上显示相等的间距 2. 测试当contentPadding变化时窗口位置保持正确 3. 检查通知在调整后的边界内正确显示 PMS: BUG-335225
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR introduces a consistent top margin for the notification center by applying the same contentPadding used for left/right margins, ensuring uniform window positioning and spacing. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review我对这段代码审查如下:
改进建议:
总体而言,这个修改是合理的,它改善了UI的一致性和美观性,同时保持了代码的简洁性和高效性。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia, yixinshark The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia, yixinshark The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Fixed notification center window positioning by adding top margin to
match the left/right margins. Previously the window was flush with
the top edge while having side margins, creating inconsistent spacing.
Now the top margin uses the same contentPadding value as the sides for
consistent visual alignment.
Influence:
changes
fix: 调整通知中心窗口位置
修复通知中心窗口位置问题,通过添加顶部边距使其与左右边距保持一致。之前窗
口顶部边缘没有边距而两侧有边距,导致间距不一致。现在顶部边距使用与两侧相
同的contentPadding值,实现一致的视觉对齐。
Influence:
PMS: BUG-335225
Summary by Sourcery
Bug Fixes: