Skip to content

fix: taskmanager context menu should use app name instead of window title #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BLumia merged 1 commit into from
Sep 24, 2025
Merged

fix: taskmanager context menu should use app name instead of window title #1271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion panels/dock/taskmanager/dockglobalelementmodel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,15 @@ QString DockGlobalElementModel::getMenus(const QModelIndex &index) const
auto row = std::get<2>(data);

QJsonArray menusArray;
menusArray.append(QJsonObject{{"id", ""}, {"name", model == m_activeAppModel ? index.data(TaskManager::WinTitleRole).toString() : tr("Open")}});
QString appNameInMenu = tr("Open");
if (model == m_activeAppModel) {
appNameInMenu = index.data(TaskManager::NameRole).toString();
// In case a window does not belongs to a known application, use the window title instead
if (appNameInMenu.isEmpty()) {
appNameInMenu = index.data(TaskManager::WinTitleRole).toString();
}
}
menusArray.append(QJsonObject{{"id", ""}, {"name", appNameInMenu}});

auto actions = model->index(row, 0).data(TaskManager::ActionsRole).toByteArray();
for (auto action : QJsonDocument::fromJson(actions).array()) {
Expand Down