fix: Popup windows was not closed when dock screen changed

[yixinshark]

close all popup windows when dock screen changed

Log: as title
Pms: BUG-288701

Summary by Sourcery

Bug Fixes:

• Add an onDockScreenChanged handler in main.qml to trigger closing of all popups via Panel.requestClosePopup()

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds a screen-change handler in main.qml that calls Panel.requestClosePopup() to close any open popups when the dock moves to another display.

File-Level Changes

Change	Details	Files
Introduce a dock screen‐changed event handler to auto-close popups	Define onDockScreenChanged() function Call Panel.requestClosePopup() inside the new handler	panels/dock/package/main.qml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[deepin-ci-robot]

deepin pr auto review

这段代码是在Dock面板中添加了一个新的信号处理器onDockScreenChanged，用于当Dock移动到另一个屏幕时关闭所有弹窗。让我对这段代码进行审查：

语法逻辑

1. 代码语法正确，符合QML的语法规范。
2. 信号处理器命名规范，清晰地表达了其功能。
3. 注释说明了代码的用途，有助于理解。

代码质量

1. 代码简洁明了，实现了预期功能。
2. 使用了已有的Panel.requestClosePopup()方法，保持了代码的一致性。
3. 将功能封装在信号处理器中，遵循了QML的响应式编程范式。

代码性能

1. 这个信号处理器非常轻量级，只调用了一个方法，对性能影响微乎其微。
2. 没有进行不必要的计算或重复操作。

代码安全

1. 代码没有直接操作UI元素，而是通过已有的方法来关闭弹窗，避免了潜在的UI状态不一致问题。
2. 没有引入新的安全风险。

改进建议

1. 可以考虑添加日志记录，以便在调试时跟踪Dock屏幕变化事件：

function onDockScreenChanged() {
    console.log("Dock screen changed, closing all popups")
    // Close all popups when dock moves to another screen
    Panel.requestClosePopup()
}

2. 如果Panel.requestClosePopup()是一个异步操作，可以考虑添加错误处理：

function onDockScreenChanged() {
    // Close all popups when dock moves to another screen
    try {
        Panel.requestClosePopup()
    } catch (e) {
        console.error("Failed to close popups when dock screen changed:", e)
    }
}

3. 如果需要更精确的控制，可以考虑添加参数来指示旧屏幕和新屏幕：

function onDockScreenChanged(oldScreen, newScreen) {
    console.log(`Dock moved from screen ${oldScreen} to screen ${newScreen}, closing all popups`)
    Panel.requestClosePopup()
}

总体而言，这段代码质量良好，实现了预期的功能，且没有明显的性能或安全问题。上述建议可以根据实际需求选择性采纳。

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, yixinshark

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment