-
Notifications
You must be signed in to change notification settings - Fork 55
feat: add clean all button for overlap notifications #1275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewer's GuideImplements a “Clean All” action for overlap notifications by adding a custom button component to the UI, extending the model’s removeByApp method to handle overlap-type notifications (with warning logs for missing apps), and updating translation files to include the new label. Class diagram for updated OverlapNotify and NotifyModelclassDiagram
class OverlapNotify {
+NotifyModel notifyModel
+var model
+customButtonComponent: AnimationSettingButton
}
class NotifyModel {
+removeByApp(appName)
-Handles Group and Overlap types
-Warning log for missing app
}
OverlapNotify --> NotifyModel: uses
AnimationSettingButton <|-- OverlapNotify: customButtonComponent
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
f5836df to
904088f
Compare
82c2f4f to
456ce25
Compare
Added a "Clean All" button to overlap notification items to allow users to remove all notifications from a specific app at once The button is implemented as a custom button component in OverlapNotify with proper translation support Modified NotifyModel to handle removal of overlap type notifications and added warning logging for missing apps Updated translation files across multiple languages to include the new "Clean All" text feat: 为重叠通知添加清除全部按钮 在重叠通知项中添加"清除全部"按钮,允许用户一次性移除特定应用的所有通知 该按钮作为自定义按钮组件在 OverlapNotify 中实现,并支持多语言翻译 修改 NotifyModel 以处理重叠类型通知的移除,并为不存在的应用添加警告日志 更新了多个语言的翻译文件以包含新的"清除全部"文本
456ce25 to
28329b6
Compare
deepin pr auto review根据提供的代码差异,我来对代码进行审查,并提出改进建议:
改进建议:
总体来说,这次代码改进是合理的,增强了通知管理的功能,并提高了代码质量和安全性。上述建议可以根据实际需求和开发计划逐步实施。 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: behind) |
Added a "Clean All" button to overlap notification items to allow users to remove all notifications from a specific app at once The button is implemented as a custom button component in OverlapNotify with proper translation support
Modified NotifyModel to handle removal of overlap type notifications and added warning logging for missing apps
Updated translation files across multiple languages to include the new "Clean All" text
feat: 为重叠通知添加清除全部按钮
在重叠通知项中添加"清除全部"按钮,允许用户一次性移除特定应用的所有通知
该按钮作为自定义按钮组件在 OverlapNotify 中实现,并支持多语言翻译
修改 NotifyModel 以处理重叠类型通知的移除,并为不存在的应用添加警告日志
更新了多个语言的翻译文件以包含新的"清除全部"文本
Summary by Sourcery
Add a “Clean All” button to overlap notification items for batch dismissal by app; integrate a custom button component in QML, extend model logic to remove overlap-type notifications with warning logs for missing apps, and update translations to include the new label
New Features:
Enhancements: