-
Notifications
You must be signed in to change notification settings - Fork 55
feat: add clean all button to notification center #1288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1. Added "Clean All" button to NotifyViewDelegate component for clearing all notifications 2. Restructured OverlapNotify component to use onRemove signal instead of inline clearButton 3. Added notifyContent property alias to OverlapNotify for external access 4. Updated translation context from "OverlapNotify" to "NotifyViewDelegate" across all language files 5. Standardized XML formatting in translation files with proper encoding and line breaks Log: Added "Clean All" button to notification center for batch notification removal Influence: 1. Test the "Clean All" button functionality in notification center 2. Verify that clicking the button removes all notifications properly 3. Check translation display for "Clean All" text in different languages 4. Test notification removal animation and behavior 5. Verify that individual notification dismissal still works correctly 6. Test with multiple notification scenarios (single, grouped, overlapping) feat: 在通知中心添加清除全部按钮 1. 在 NotifyViewDelegate 组件中添加"清除全部"按钮用于清理所有通知 2. 重构 OverlapNotify 组件,使用 onRemove 信号替代内联 clearButton 3. 添加 notifyContent 属性别名以便外部访问 4. 在所有语言文件中将翻译上下文从"OverlapNotify"更新 为"NotifyViewDelegate" 5. 统一翻译文件的 XML 格式,包含正确的编码和换行符 Log: 新增通知中心"清除全部"按钮,支持批量删除通知 Influence: 1. 测试通知中心"清除全部"按钮功能 2. 验证点击按钮后所有通知是否正确移除 3. 检查不同语言环境下"清除全部"文本的翻译显示 4. 测试通知移除动画和行为 5. 验证单个通知的关闭功能是否仍然正常工作 6. 测试多种通知场景(单个、分组、重叠) PMS: BUG-336149
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewer's GuideThis PR implements a “Clean All” batch removal feature by adding a clear button in the NotifyViewDelegate component, refactors the OverlapNotify component to emit an onRemove signal (with a new notifyContent alias) instead of an inline button, and standardizes translation contexts and XML formatting across all TS files. Sequence diagram for batch notification removal via 'Clean All' buttonsequenceDiagram
actor User
participant NotifyViewDelegate
participant notifyContent
User->>NotifyViewDelegate: Clicks 'Clean All' button
NotifyViewDelegate->>notifyContent: clearButton.onClicked()
notifyContent->>notifyContent: remove()
notifyContent->>NotifyViewDelegate: Notifies removal complete
NotifyViewDelegate->>User: Updates UI (notifications cleared)
Class diagram for NotifyViewDelegate and OverlapNotify changesclassDiagram
class NotifyViewDelegate {
+clearButton: AnimationSettingButton
+notifyContent: alias
}
class OverlapNotify {
+onRemove: signal
+notifyContent: alias
}
NotifyViewDelegate "1" -- "1" OverlapNotify: uses
OverlapNotify <|-- notifyContent: alias
NotifyViewDelegate <|-- notifyContent: alias
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: blocked) |
all notifications
of inline clearButton
access
"NotifyViewDelegate" across all language files
and line breaks
Log: Added "Clean All" button to notification center for batch
notification removal
Influence:
overlapping)
feat: 在通知中心添加清除全部按钮
为"NotifyViewDelegate"
Log: 新增通知中心"清除全部"按钮,支持批量删除通知
Influence:
PMS: BUG-336149
Summary by Sourcery
Add a bulk "Clean All" button to the notification center and refactor notification components to streamline removal logic
New Features:
Enhancements: