Skip to content

Fix few memory leaks #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
csfercoci wants to merge 6 commits into from
Closed

Fix few memory leaks #1289

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dc75062
Fix: Replace MultiEffect with FastBlur to improve performance
google-labs-jules[bot] Oct 8, 2025
b269986
Fix: Improve performance and stability of dde-shell
google-labs-jules[bot] Oct 8, 2025
400979d
Fix: Improve performance and stability of dde-shell
google-labs-jules[bot] Oct 9, 2025
342fe9f
Fix: Resolve memory leaks and improve stability in dde-shell
google-labs-jules[bot] Oct 9, 2025
0618fa6
This commit addresses several critical issues to improve the long-ter…
google-labs-jules[bot] Oct 9, 2025
6de56b2
This commit addresses several critical issues to improve the long-ter…
google-labs-jules[bot] Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion panels/dock/dockdbusproxy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ DockDBusProxy::DockDBusProxy(DockPanel* parent)
};

// TODO: DQmlGlobal maybe missing a signal which named `appletListChanged`?
QTimer *timer = new QTimer;
QTimer *timer = new QTimer(this);
timer->setInterval(1000);
connect(timer, &QTimer::timeout, this, [ = ] {
if (getOtherApplet()) {
Expand Down
4 changes: 2 additions & 2 deletions panels/dock/dockpanel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,10 @@ bool DockPanel::init()
if (m_dockScreen) {
if (m_dockScreen != window()->screen() && qApp->screens().contains( m_dockScreen)) {
qWarning() << "m_dockScreen" << m_dockScreen << m_dockScreen->name() << "window()->screen()" << window()->screen() << window()->screen()->name();
QTimer::singleShot(10, this, [this](){
QMetaObject::invokeMethod(this, [this](){
window()->setScreen(m_dockScreen);
onWindowGeometryChanged();
});
}, Qt::QueuedConnection);
} else {
onWindowGeometryChanged();
}
Expand Down
7 changes: 7 additions & 0 deletions panels/dock/taskmanager/rolegroupmodel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,14 @@
RoleGroupModel::setSourceModel(sourceModel);
}

RoleGroupModel::~RoleGroupModel()
{
qDeleteAll(m_rowMap);
m_rowMap.clear();
m_map.clear();
}

void RoleGroupModel::setDeduplicationRole(const int &role)

Check warning on line 23 in panels/dock/taskmanager/rolegroupmodel.cpp

View workflow job for this annotation

GitHub Actions / cppcheck 

The function 'setDeduplicationRole' is never used.
{
if (role != m_roleForDeduplication) {
m_roleForDeduplication = role;
Expand Down
1 change: 1 addition & 0 deletions panels/dock/taskmanager/rolegroupmodel.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ class RoleGroupModel : public QAbstractProxyModel

public:
explicit RoleGroupModel(QAbstractItemModel *sourceModel, int role, QObject *parent = nullptr);
~RoleGroupModel();
void setSourceModel(QAbstractItemModel *sourceModel) override;

void setDeduplicationRole(const int &role);
Expand Down
8 changes: 2 additions & 6 deletions shell/InWindowBlur.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,11 @@ Item {
}
color: Window.window && Window.window.color.a < 1 ? D.ColorSelector.overlay : "transparent"

MultiEffect {
FastBlur {
id: blur
anchors.fill: parent
source: blitter.content
autoPaddingEnabled: false
blurEnabled: true
blur: 1.0
blurMax: 64
saturation: 0.4
radius: 64
}
}
}
Expand Down
Loading