-
Notifications
You must be signed in to change notification settings - Fork 55
fix: shadow too hard caused by incorrect Qt.rgba usage #1351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
由于对 Qt.rgba() 的误用导致阴影过硬,任务栏在下方时由于阴影方向是右下 所以不明显,在左/上/右时很显著. 此处对误用进行修正,使用默认阴影透明度(60%). PMS: BUG-331251, BUG-339199 Log:
Reviewer's guide (collapsed on small PRs)Reviewer's GuideCorrects the shadow color assignment by using the proper normalized alpha value for Qt.rgba, restoring the intended 60% opacity and improving comment context. Class diagram for updated DWindow shadowColor assignmentclassDiagram
class Window {
}
class D_DWindow {
shadowColor
borderWidth
enableBlurWindow
themeType
shadowColor = hideShowAnimation.running ? Qt.rgba(0, 0, 0, 0) : Qt.rgba(0, 0, 0, 0.6)
borderWidth = hideShowAnimation.running ? 0 : 1
}
Window --> D_DWindow: uses
class hideShowAnimation {
running
}
Window --> hideShowAnimation: uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review我来对这段代码变更进行审查:
总体评价:
建议保持这个改动,它提高了代码质量而不影响功能。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
由于对 Qt.rgba() 的误用导致阴影过硬,任务栏在下方时由于阴影方向是右下所以不明显,在左/上/右时很显著.
此处对误用进行修正,使用默认阴影透明度(60%).
Summary by Sourcery
Bug Fixes: