Skip to content

KExtraColumnsProxyModel: port to Qt 6.8's QIdentityProxyModel::setHandleSourceLayoutChanges #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BLumia merged 1 commit into from
Nov 27, 2024
Merged

KExtraColumnsProxyModel: port to Qt 6.8's QIdentityProxyModel::setHandleSourceLayoutChanges #898

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions frame/models/kextracolumnsproxymodel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,11 @@ KExtraColumnsProxyModel::KExtraColumnsProxyModel(QObject *parent)
: QIdentityProxyModel(parent)
, d_ptr(new KExtraColumnsProxyModelPrivate(this))
{
// The handling of persistent model indexes assumes mapToSource can be called for any index
// This breaks for the extra column, so we'll have to do it ourselves
#if QT_VERSION >= QT_VERSION_CHECK(6, 8, 0)
setHandleSourceLayoutChanges(false);
#endif
}

KExtraColumnsProxyModel::~KExtraColumnsProxyModel()
Expand Down Expand Up @@ -96,6 +101,7 @@ void KExtraColumnsProxyModel::setSourceModel(QAbstractItemModel *model)
if (model) {
// The handling of persistent model indexes assumes mapToSource can be called for any index
// This breaks for the extra column, so we'll have to do it ourselves
#if QT_VERSION < QT_VERSION_CHECK(6, 8, 0)
disconnect(model,
SIGNAL(layoutAboutToBeChanged(QList<QPersistentModelIndex>, QAbstractItemModel::LayoutChangeHint)),
this,
Expand All @@ -104,6 +110,7 @@ void KExtraColumnsProxyModel::setSourceModel(QAbstractItemModel *model)
SIGNAL(layoutChanged(QList<QPersistentModelIndex>, QAbstractItemModel::LayoutChangeHint)),
this,
SLOT(_q_sourceLayoutChanged(QList<QPersistentModelIndex>, QAbstractItemModel::LayoutChangeHint)));
#endif
connect(model,
SIGNAL(layoutAboutToBeChanged(QList<QPersistentModelIndex>, QAbstractItemModel::LayoutChangeHint)),
this,
Expand Down
Loading