fix: Avoid empty notification. #928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yixinshark
force-pushed
the
fix-emptyNotification
branch
2 times, most recently
from
132b0a1 to
5bf0fc8
Compare
18202781743
reviewed
Dec 5, 2024
|
|
||
| if (entity.processedType() != NotifyEntity::None) { | ||
| qint64 id = m_persistence->addEntity(entity); | ||
| if (id == -1) { |
Contributor
Author
There was a problem hiding this comment.
addEntity错误返回的是0,
以将错误返回改为-1
18202781743
reviewed
Dec 5, 2024
yixinshark
force-pushed
the
fix-emptyNotification
branch
5 times, most recently
from
856e459 to
5d34ef7
Compare
as title Log: as title
yixinshark
force-pushed
the
fix-emptyNotification
branch
from
5d34ef7 to
99c29be
Compare
deepin pr auto review关键摘要:
是否建议立即修改: |
18202781743
approved these changes
Dec 6, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, yixinshark The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/forcemerge |
|
This pr force merged! (status: blocked) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title
Log: as title