Skip to content

Conversation

@tsic404
Copy link
Contributor

@tsic404 tsic404 commented Dec 5, 2024

Asynchronous calls and cached dbus call results

log: as title

Asynchronous calls and cached dbus call results

log: as title
@tsic404 tsic404 requested a review from 18202781743 December 5, 2024 08:37
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • initDBusProxy函数中新增了两个设置,setSync(false)setUseCache(true),需要确认这些设置是否符合业务逻辑需求。
  • 新增的设置没有注释说明其目的和影响,建议添加相应的注释以提高代码可读性。

是否建议立即修改:

  • 是,建议立即添加注释,并确认新增设置是否符合业务逻辑需求。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tsic404, yixinshark

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tsic404
Copy link
Contributor Author

tsic404 commented Dec 6, 2024

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Dec 6, 2024

This pr force merged! (status: unknown)

@deepin-bot deepin-bot bot merged commit 9310f17 into linuxdeepin:master Dec 6, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants