Skip to content

Conversation

@tsic404
Copy link
Contributor

@tsic404 tsic404 commented Dec 6, 2024

When dragging occurs, the MouseReleaseEvent outside the popup will be a dropEvent,and the window will no longer be closed.

log: as title
pms: BUG-291969

When dragging occurs, the MouseReleaseEvent outside the popup will be a dropEvent,and the window will no longer be closed.

log: as title
pms: BUG-291969
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • mouseReleaseEvent函数中,m_draggingm_pressing的赋值操作应该放在if语句之外,以确保无论条件是否满足,这两个变量都能正确更新。
  • mousePressEventmouseMoveEvent函数中的return语句可以省略,因为它们是虚函数的覆盖,不需要显式返回。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, tsic404

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tsic404
Copy link
Contributor Author

tsic404 commented Dec 6, 2024

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Dec 6, 2024

This pr force merged! (status: behind)

@deepin-bot deepin-bot bot merged commit ab3b997 into linuxdeepin:master Dec 6, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants