Skip to content

Conversation

@BLumia
Copy link
Member

@BLumia BLumia commented Dec 6, 2024

将应用图标拖出任务栏时,即取消固定。

PMS: BUG-284079 BUG-291165

@BLumia BLumia requested a review from tsic404 December 6, 2024 03:47
@BLumia BLumia force-pushed the pms-291165 branch 3 times, most recently from 9044411 to 3c6f6cd Compare December 6, 2024 06:38
将应用图标拖出任务栏时,即取消固定。

PMS: BUG-284079 BUG-288773
Log:
@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. ItemModel::moveTo函数中,增加了对dIndex的检查,这是一个好的做法,可以避免潜在的越界访问错误。

  2. AppItem.qml文件中,Drag.mimeData属性增加了新的键值对"text/x-dde-dock-dnd-source": "taskbar",这可能是为了区分拖拽源,但需要确认这个改动是否符合整体的设计和需求。

  3. TaskManager.qml文件中,ContainmentItem组件的visibility属性被修改,现在它依赖于taskmanager.Applet.desktopIdToAppId函数的结果。这可能是为了确保itemId的正确性,但需要确保这个函数的实现是正确的,并且不会引入新的问题。

  4. TaskManager.qml文件中,launcherDndDropArea组件增加了launcherDndDragSource属性和resetDndState函数,这可能是为了处理拖拽源的不同情况。需要确保这些改动不会影响现有的功能,并且已经通过了充分的测试。

  5. TaskManager.cpp文件中,requestDockByDesktopId函数的参数名从appID改为desktopID,这可能是为了保持参数名的一致性。需要确保这个改动不会影响其他部分的代码。

  6. TaskManager.cpp文件中,新增了requestUndockByDesktopId函数,这可能是为了处理应用程序的取消停靠请求。需要确保这个函数的实现是正确的,并且已经通过了充分的测试。

  7. TaskManager.h文件中,requestDockByDesktopId函数的参数名从appID改为desktopID,这可能是为了保持参数名的一致性。需要确保这个改动不会影响其他部分的代码。

总体来说,这些改动看起来是合理的,但需要进一步的测试和验证以确保它们不会引入新的问题。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, tsic404

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit d8760e2 into linuxdeepin:master Dec 6, 2024
7 of 10 checks passed
@BLumia BLumia deleted the pms-291165 branch January 20, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants