Skip to content

Conversation

@yixinshark
Copy link
Contributor

@yixinshark yixinshark commented Dec 9, 2024

Setting multitaskView plugin visible, has no pluginVisibleChanged signal.

as title

Log: as title
pms: BUG-286925

…d signal.

as title

Log: as title
pms: BUG-286925
@yixinshark yixinshark force-pushed the fix-multitaskViewVisibleChanged branch from ced20f7 to 6417d16 Compare December 10, 2024 05:31
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在新增代码中,Q_EMIT pluginVisibleChanged(itemKey, visible); 被重复调用,应该检查是否需要移除其中一个。
  • QMetaObject::invokeMethod 使用了 Qt::QueuedConnection,这可能会导致延迟,应该评估是否需要立即调用。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, yixinshark

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yixinshark
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Dec 10, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 0c07d2c into linuxdeepin:master Dec 10, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants