Skip to content

Conversation

@18202781743
Copy link
Contributor

std::numeric_limits::max() cause dbus_message protocol error.

std::numeric_limits<unit>::max() cause dbus_message protocol error.
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • dbusadaptor.cpp文件中,将id == std::numeric_limits<uint>::max()的判断条件更改为id == 0可能会改变原有的错误处理逻辑,需要确认这一改动是否符合预期。
  • notificationmanager.cpp文件中,当保存数据库失败时,应该抛出异常而不是返回一个错误码,以便调用者能够正确处理错误。

是否建议立即修改:

  • 是,需要确认dbusadaptor.cpp中的条件判断改动是否符合业务逻辑,并确保notificationmanager.cpp中的错误处理方式是正确的。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, yixinshark

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Dec 10, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 86ed27a into linuxdeepin:master Dec 10, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants