chore: Add 'enable-sound' to support notification without playing pro… #957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yixinshark
force-pushed
the
chore-hintsEnableSound
branch
from
13ca8a9 to
9c83581
Compare
18202781743
reviewed
Dec 12, 2024
| void NotificationManager::tryPlayNotificationSound(const NotifyEntity &entity, const QString &appId, bool dndMode) const | ||
| { | ||
| const auto hints = entity.hints(); | ||
| if (!hints.isEmpty() && hints.value("enable-sound", false).toBool()) { |
yixinshark
force-pushed
the
chore-hintsEnableSound
branch
from
9c83581 to
67ccb65
Compare
deepin pr auto review关键摘要:
是否建议立即修改:
|
…mpt sound as title Log: as title pms: BUG-293913
yixinshark
force-pushed
the
chore-hintsEnableSound
branch
from
67ccb65 to
da8f733
Compare
18202781743
approved these changes
Dec 12, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, yixinshark The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/forcemerge |
|
This pr force merged! (status: blocked) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mpt sound
as title
Log: as title
pms: BUG-293913