Skip to content

Conversation

@18202781743
Copy link
Contributor

Dismissed notify doesn't move to notification center.
Disable dismissed of overlap notification for notification center.

pms: TASK-366403

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, yixinshark

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Dismissed notify doesn't move to notification center.
Disable dismissed of overlap notification for notification center.

pms: TASK-366403
@18202781743
Copy link
Contributor Author

/forcemerge

@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. BubblePanel::close函数中,新增了一个reason参数,但是在调用该函数时,没有更新所有调用该函数的地方,可能会导致逻辑错误。建议检查所有调用close函数的地方,确保它们都传递了正确的reason参数。

  2. NotifyItem.qmlNotifyItemContent.qml中,新增了defaultAction属性,但是在NotifyItemContentTapHandler中,onTapped函数中使用了root.defaultAction,但是没有检查defaultAction是否为空。建议添加空值检查,以避免潜在的空指针异常。

  3. NotifyItem.qml中,新增了CloseReason枚举,但是在NotifyItemContent.qmlTapHandler中,onTapped函数中使用了root.defaultAction,但是没有使用CloseReason枚举来表示关闭原因。建议更新onTapped函数,使用CloseReason枚举来表示关闭原因。

  4. NotifyAccessor::closeNotify函数中,新增了一个reason参数,但是在调用该函数时,没有更新所有调用该函数的地方,可能会导致逻辑错误。建议检查所有调用closeNotify函数的地方,确保它们都传递了正确的reason参数。

  5. NotifyStagingModel::closeNotify函数中,新增了一个reason参数,但是在调用该函数时,没有更新所有调用该函数的地方,可能会导致逻辑错误。建议检查所有调用closeNotify函数的地方,确保它们都传递了正确的reason参数。

  6. NotificationManager::updateEntityProcessed函数中,新增了一个条件判断,但是没有更新所有调用该函数的地方,可能会导致逻辑错误。建议检查所有调用updateEntityProcessed函数的地方,确保它们都传递了正确的reason参数。

以上是代码审查意见,希望能够帮助到您。

@deepin-bot
Copy link

deepin-bot bot commented Dec 24, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 8de5c6a into linuxdeepin:master Dec 24, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants