Skip to content

Conversation

@BLumia
Copy link
Member

@BLumia BLumia commented Nov 19, 2025

移除 de_DE 翻译资源,仅保留 de (不带地区变体后缀)的资源.

相关:

Summary by Sourcery

Chores:

  • Delete de_DE and de_CH translation files for multiple plugins

移除 de_DE 翻译资源,仅保留 de (不带地区变体后缀)的资源.

Log:
@BLumia BLumia requested a review from wjyrich November 19, 2025 04:03
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sourcery-ai
Copy link

sourcery-ai bot commented Nov 19, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR removes all German regional variant translation files (de_DE and de_CH), retaining only the base 'de' resources across dock, wirelesscasting plugin, and trayplugin loader components.

File-Level Changes

Change Details Files
Clean up dock plugin German regional translations
  • Deleted de_CH translation file
  • Deleted de_DE translation file
plugins/dde-dock/translations/dde-dock_de_CH.ts
plugins/dde-dock/translations/dde-dock_de_DE.ts
Clean up wirelesscasting plugin German regional translations
  • Deleted de_CH translation file
  • Deleted de_DE translation file
plugins/dde-network-display-ui/plugins/dock-wirelesscasting-plugin/translations/dock-wirelesscasting-plugin_de_CH.ts
plugins/dde-network-display-ui/plugins/dock-wirelesscasting-plugin/translations/dock-wirelesscasting-plugin_de_DE.ts
Remove trayplugin loader German regional translation
  • Deleted de_DE translation file
src/loader/translations/trayplugin-loader_de_DE.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link

deepin pr auto review

这是一个 Git diff 输出,显示了一些德语翻译文件(.ts)的删除操作。让我对这些文件进行代码审查:

  1. 代码质量:
  • 这些是 Qt 翻译文件,使用 XML 格式存储
  • 文件结构规范,包含了必要的 XML 声明和 DOCTYPE
  • 每个翻译项都正确地包含了 source 和 translation 标签
  1. 翻译质量:
  • de_DE.ts 文件中包含了完整的德语翻译
  • de_CH.ts 文件中所有翻译项都标记为 "unfinished",表明这些翻译未完成
  • 一些翻译可能需要本地化调整,比如日期格式、数字格式等
  1. 性能考虑:
  • 这些是静态翻译文件,不会影响运行时性能
  • 文件大小适中,不会造成显著的存储开销
  1. 安全性:
  • 文件不包含任何可执行代码,没有安全风险
  • 翻译内容不包含敏感信息

改进建议:

  1. 对于 de_CH.ts:
  • 建议完成所有标记为 "unfinished" 的翻译
  • 考虑与 de_DE.ts 的差异,确保符合瑞士德语的语言习惯
  1. 对于 de_DE.ts:
  • 检查翻译的一致性,比如 "Enable" 在不同地方翻译为 "Aktivieren" 和 "Deaktivieren"
  • 确保专业术语的准确性,如 "Hibernate" 翻译为 "Ruhezustand"
  • 建议添加翻译注释,说明某些特定翻译选择的原因
  1. 通用建议:
  • 建议建立翻译术语表,确保术语一致性
  • 考虑使用翻译管理工具来维护这些文件
  • 定期审查和更新翻译,特别是涉及新功能的部分
  1. 文件管理:
  • 建议保留这些文件的版本历史
  • 考虑将翻译文件与源代码分开管理
  • 建立翻译文件的审查流程

这些改进建议将有助于提高翻译质量和维护效率,同时确保用户界面的本地化体验。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, wjyrich

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit 30f3f20 into linuxdeepin:master Nov 19, 2025
10 of 11 checks passed
@BLumia BLumia deleted the remove-de_DE branch November 19, 2025 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants