fix: Handling translation errors in lo languages#359
Merged
lzwind merged 1 commit intolinuxdeepin:masterfrom Aug 8, 2025
Merged
fix: Handling translation errors in lo languages#359lzwind merged 1 commit intolinuxdeepin:masterfrom
lzwind merged 1 commit intolinuxdeepin:masterfrom
Conversation
|
TAG Bot TAG: 6.0.39 |
Reviewer's GuideThis PR refines the Lao translation files by realigning source location tags across C++ and QML contexts, marking obsolete entries and adding new dialog/SearchView contexts with unfinished translations, introduces pluralization (numerus) support for photo/video counts, and bumps the application version in packaging manifests. Class diagram for translation context and pluralization changesclassDiagram
class TranslationEntry {
- source: string
- translation: string
- location: string
- numerus: bool
- type: string (e.g., "vanished", "unfinished")
}
class TranslationContext {
- name: string
- entries: List<TranslationEntry>
}
class TranslationFile {
- contexts: List<TranslationContext>
}
TranslationFile --> TranslationContext
TranslationContext --> TranslationEntry
%% Highlight pluralization support
class TranslationEntry {
+numerus: bool
}
%% Highlight new/obsolete entries
class TranslationEntry {
+type: string
}
Class diagram for packaging manifest version updateclassDiagram
class PackageManifest {
- id: string
- name: string
- version: string
- kind: string
- description: string
}
PackageManifest <|-- Arm64Manifest
PackageManifest <|-- Loong64Manifest
PackageManifest <|-- MainManifest
%% Version field updated from 6.0.38.1 to 6.0.39.1
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @JWWTSL - I've reviewed your changes - here's some feedback:
- Several new strings (e.g. in RemoveAlbumDialog, RemoveDialog, and SearchView contexts) are still marked as type="unfinished" and need proper Lao translations.
- Pluralized messages (numerus) for "%n photos", "%n videos", and "%n items" only include a single and require explicit cases for all plural forms according to Lao grammatical rules.
- There are numerous entries; consider removing obsolete translations to keep the TS file clean and in sync with source.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Several new strings (e.g. in RemoveAlbumDialog, RemoveDialog, and SearchView contexts) are still marked as type="unfinished" and need proper Lao translations.
- Pluralized messages (numerus) for "%n photos", "%n videos", and "%n items" only include a single <numerusform> and require explicit cases for all plural forms according to Lao grammatical rules.
- There are numerous <message type="vanished"> entries; consider removing obsolete translations to keep the TS file clean and in sync with source.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| <name>RemoveDialog</name> | ||
| <message> | ||
| <location filename="../qml/PreviewImageViewer/Dialog/RemoveDialog.qml" line="66"/> | ||
| <source>Cannot move "%1" to the trash. Do you want to permanently delete it?</source> |
There was a problem hiding this comment.
issue (code-quality): Delete should only be used for object properties. (only-delete-object-properties)
Explanation
The `delete` operator is intended for use in deleting the properties of objects, and does not have meaningful behaviour otherwise.
lzwind
approved these changes
Aug 8, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JWWTSL, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This was referenced Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
log:
Summary by Sourcery
Correct and enhance Lao (lo) locale translations by fixing existing string errors, adding missing entries for new dialogs and search view, marking outdated entries as vanished, and bumping the application version to 6.0.39.1.
New Features:
Bug Fixes:
Enhancements:
Build: