Skip to content

chore: Update .gitignore and clean up Lao translations#362

Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
dengzhongyuan365-dev:master
Aug 12, 2025
Merged

chore: Update .gitignore and clean up Lao translations#362
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
dengzhongyuan365-dev:master

Conversation

@dengzhongyuan365-dev
Copy link
Copy Markdown
Contributor

@dengzhongyuan365-dev dengzhongyuan365-dev commented Aug 12, 2025

  • Added .cursor and .cursorindexingignore to .gitignore
  • Removed unused translation entries in deepin-album_lo.ts
  • Updated existing translations for consistency

Summary by Sourcery

Update .gitignore to ignore cursor artifacts and clean up Lao translation file by removing obsolete entries and standardizing translations

Enhancements:

  • Ignore .cursor and .cursorindexingignore files via .gitignore update
  • Remove obsolete and vanished Lao translation entries from deepin-album_lo.ts
  • Standardize Lao translations by updating plural forms and date abbreviations

- Added .cursor and .cursorindexingignore to .gitignore
- Removed unused translation entries in deepin-album_lo.ts
- Updated existing translations for consistency
Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dengzhongyuan365-dev - I've reviewed your changes - here's some feedback:

  • Ensure that the new .cursorindexingignore entry in .gitignore matches your actual file naming conventions or consider using wildcard patterns to cover any similar temporary files consistently.
  • After removing the ‘vanished’ messages from the Lao TS file, run lupdate to confirm no source strings are reintroduced or causing missing translations.
  • Double-check that the updated single-letter translations for ‘M’ and ‘D’ don’t conflict with UI shortcuts or tooltip contexts in the AlbumTitle component.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Ensure that the new .cursorindexingignore entry in .gitignore matches your actual file naming conventions or consider using wildcard patterns to cover any similar temporary files consistently.
- After removing the ‘vanished’ messages from the Lao TS file, run lupdate to confirm no source strings are reintroduced or causing missing translations.
- Double-check that the updated single-letter translations for ‘M’ and ‘D’ don’t conflict with UI shortcuts or tooltip contexts in the AlbumTitle component.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Aug 12, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Extends .gitignore to ignore cursor artifacts and cleans up and standardizes Lao translations by removing obsolete entries and updating translation strings and plural forms for consistency.

File-Level Changes

Change Details Files
Updated .gitignore to exclude cursor-related files
  • Added .cursor to ignore list
  • Added .cursorindexingignore to ignore list
.gitignore
Removed obsolete translation entries
  • Removed vanished messages for deprecated sources
  • Deleted unused translation blocks across multiple contexts
src/translations/deepin-album_lo.ts
Standardized Lao translation strings and plural forms
  • Adjusted translations for 'M' and 'D' tokens
  • Filled in missing plural variants for photos, videos, items
  • Refined existing translation text for consistency
src/translations/deepin-album_lo.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dengzhongyuan365-dev, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dengzhongyuan365-dev
Copy link
Copy Markdown
Contributor Author

/forcemerge

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot bot commented Aug 12, 2025

This pr force merged! (status: unstable)

@deepin-bot deepin-bot bot merged commit 33a8cd7 into linuxdeepin:master Aug 12, 2025
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants