Skip to content

Conversation

@myml
Copy link
Member

@myml myml commented Mar 5, 2025

支持根据区域使用不同的服务器

支持根据区域使用不同的服务器
@myml
Copy link
Member Author

myml commented Mar 5, 2025

/integrate

@github-actions
Copy link

github-actions bot commented Mar 5, 2025

AutoIntegrationPr Bot
auto integrate with pr url: deepin-community/Repository-Integration#2656
PrNumber: 2656
PrBranch: auto-integration-13670295260

Log: 发布1.6.4版本, 优化网络情况
@myml
Copy link
Member Author

myml commented Mar 5, 2025

/integrate

@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • homeDaemon.cpp文件中,getServer函数中新增了根据系统语言选择服务器的逻辑,但未处理可能出现的异常情况,例如系统语言不是"CN"也不是"DE"的情况。
  • getServer函数中,m_settings.setValue("server_" + region, server);这行代码可能会覆盖用户之前设置的服务器地址,应该考虑是否需要保留原有的设置。
  • run函数中新增的日志输出可能会泄露敏感信息,如m_nodegetMachineID()的值,应该确保这些信息不会在日志中暴露。

是否建议立即修改:

  • 应该添加对系统语言不是"CN"也不是"DE"情况的处理逻辑,以避免潜在的运行时错误。
  • 考虑是否需要保留用户之前设置的服务器地址,以避免不必要的数据覆盖。
  • 确保日志输出不会泄露敏感信息,或者至少对敏感信息进行适当的脱敏处理。

@github-actions
Copy link

github-actions bot commented Mar 5, 2025

TAG Bot

TAG: 1.6.4
EXISTED: no
DISTRIBUTION: UNRELEASED

@myml myml requested a review from justforlxz March 17, 2025 03:31
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: justforlxz, myml

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@myml myml merged commit 30be851 into linuxdeepin:master Mar 17, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants