Skip to content

sync: from linuxdeepin/dtkwidget#105

Merged
18202781743 merged 1 commit intomasterfrom
sync-pr-628-nosync
Jan 2, 2025
Merged

sync: from linuxdeepin/dtkwidget#105
18202781743 merged 1 commit intomasterfrom
sync-pr-628-nosync

Conversation

@deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#628

@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#628
@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • q->close(); 直接调用 close() 方法,可能需要确认这是否符合设计要求,因为 windowHandle()->close(); 可能会触发特定的关闭逻辑。
  • 移除了对 windowHandle() 的检查,这可能会影响关闭窗口时的行为,需要确认这一改动是否符合预期。

是否建议立即修改:

  • 是,需要确认关闭窗口的逻辑是否正确,并确保移除 windowHandle() 检查后的行为符合设计要求。

@18202781743 18202781743 merged commit 940aa00 into master Jan 2, 2025
6 checks passed
@18202781743 18202781743 deleted the sync-pr-628-nosync branch January 2, 2025 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants