Skip to content

feat: increase fallback for password character#646

Merged
mhduiy merged 1 commit intolinuxdeepin:masterfrom
mhduiy:fixFont
Mar 18, 2025
Merged

feat: increase fallback for password character#646
mhduiy merged 1 commit intolinuxdeepin:masterfrom
mhduiy:fixFont

Conversation

@mhduiy
Copy link
Contributor

@mhduiy mhduiy commented Mar 12, 2025

0x26ab code points support fewer fonts, so we added 0x25CF with a wider range of adaptability as a fallback

pms: BUG-305575

deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Mar 12, 2025
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#646
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Mar 12, 2025
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#646
@mhduiy mhduiy requested a review from 18202781743 March 12, 2025 08:31
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Mar 12, 2025
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#646
18202781743
18202781743 previously approved these changes Mar 12, 2025
0x26ab code points support fewer fonts, so we added 0x25CF with a wider range of adaptability as a fallback

pms: BUG-305575
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • styleHint函数中,if语句的返回值和else语句的返回值不一致,可能导致逻辑错误。
  • QFontMetrics(w->font()).inFont(QChar(0x26AB))的返回值被忽略,可能没有正确处理字符是否在字体中的情况。

是否建议立即修改:

deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Mar 12, 2025
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#646
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mhduiy mhduiy merged commit add9c2a into linuxdeepin:master Mar 18, 2025
18 of 21 checks passed
mhduiy pushed a commit to linuxdeepin/dtk6widget that referenced this pull request Mar 18, 2025
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants