Skip to content

fix: accessing wild pointer for DAboutDialog#647

Merged
18202781743 merged 1 commit intolinuxdeepin:masterfrom
18202781743:master
Mar 19, 2025
Merged

fix: accessing wild pointer for DAboutDialog#647
18202781743 merged 1 commit intolinuxdeepin:masterfrom
18202781743:master

Conversation

@18202781743
Copy link
Contributor

acknowledgementLabel is wild pointer if DDialog::clearContents
is called.
aboutDialog->setLicenseEnabled is not need to call when reactive
the dialog

pms: TASK-368399

@18202781743 18202781743 requested review from BLumia and mhduiy March 13, 2025 03:05
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Mar 13, 2025
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#647
BLumia
BLumia previously approved these changes Mar 13, 2025
acknowledgementLabel is wild pointer if DDialog::clearContents
is called.
aboutDialog->setLicenseEnabled is not need to call when reactive
the dialog

pms: TASK-368399
@18202781743 18202781743 requested a review from BLumia March 18, 2025 12:21
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Mar 18, 2025
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#647
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • 删除了 d->aboutDialog->setLicenseEnabled(d->licenseDialog->isValid()); 这行代码,需要确认这是否是有意为之,以及是否有其他代码负责设置许可证状态。

是否建议立即修改:

  • 是,如果删除这行代码是无意的,应该立即恢复,并确保许可证状态能够正确设置。
  • 否,如果是有意为之,需要确保相关的功能在其他地方得到了适当的处理。

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit c611da8 into linuxdeepin:master Mar 19, 2025
18 of 21 checks passed
18202781743 pushed a commit to linuxdeepin/dtk6widget that referenced this pull request Mar 19, 2025
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#647
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants