Skip to content

build: compiling failed with Qt 6.9#656

Merged
ComixHe merged 1 commit intolinuxdeepin:masterfrom
ComixHe:master
Apr 18, 2025
Merged

build: compiling failed with Qt 6.9#656
ComixHe merged 1 commit intolinuxdeepin:masterfrom
ComixHe:master

Conversation

@ComixHe
Copy link
Contributor

@ComixHe ComixHe commented Apr 18, 2025

No description provided.

@ComixHe ComixHe requested a review from 18202781743 April 18, 2025 04:10
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Apr 18, 2025
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#656
Signed-off-by: ComixHe <heyuming@deepin.org>
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • dlabel.cpp文件中,#include <private/qhexstring_p.h>的添加可能不是必要的,除非DPaletteHelperqlabel_p.h中确实使用了qhexstring_p.h
  • dlabel.cpp文件中,paintEvent函数的修改可能会影响性能,因为每次绘制时都会重新计算scaledSizescaledpixmap。建议缓存这些值以避免重复计算。
  • dlabel.cpp文件中,paintEvent函数的修改增加了代码的复杂性,特别是对于#else部分的添加。建议重构代码以减少条件分支的数量,并提高代码的可读性。
  • dlabel.cpp文件中,paintEvent函数的修改引入了新的HexString命名空间的使用,需要确保这个命名空间在所有相关文件中都是可用的。
  • dtitlebarsettings.cpp文件中,moc_dtitlebarsettings.cpp的包含位置被移动到了文件末尾,这通常是一个好的做法,因为它可以确保所有相关的类和函数都已经被定义。

是否建议立即修改:

  • 确认#include <private/qhexstring_p.h>是否必要,如果不是,应该移除它以避免不必要的依赖。
  • 优化paintEvent函数中的性能问题,特别是关于scaledSizescaledpixmap的计算。
  • 重构paintEvent函数中的代码,以减少条件分支的数量,并提高代码的可读性和可维护性。
  • 确保所有使用HexString命名空间的地方都正确处理了命名空间的使用。
  • 保持moc_dtitlebarsettings.cpp的包含位置在文件末尾,这是一个好的实践,应该保持不变。

deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Apr 18, 2025
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#656
@ComixHe ComixHe requested a review from 18202781743 April 18, 2025 05:37
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, ComixHe

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ComixHe ComixHe merged commit be61a18 into linuxdeepin:master Apr 18, 2025
18 of 21 checks passed
ComixHe pushed a commit to linuxdeepin/dtk6widget that referenced this pull request Apr 18, 2025
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#656
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants