Skip to content

fix: watermark can't select picture for PrintPreivew#657

Merged
18202781743 merged 1 commit intolinuxdeepin:masterfrom
18202781743:master
Apr 18, 2025
Merged

fix: watermark can't select picture for PrintPreivew#657
18202781743 merged 1 commit intolinuxdeepin:masterfrom
18202781743:master

Conversation

@18202781743
Copy link
Contributor

incorrect format for dialog's filter.

pms: BUG-311847

@18202781743 18202781743 requested review from BLumia and mhduiy April 18, 2025 06:16
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Apr 18, 2025
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#657
ComixHe pushed a commit to linuxdeepin/dtk6widget that referenced this pull request Apr 18, 2025
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#657
incorrect format for dialog's filter.

pms: BUG-311847
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • setNameFilters 方法中的文件类型过滤字符串使用了 qApp->translate 进行翻译,这可能会导致文件类型过滤字符串的国际化问题。

是否建议立即修改:

建议的修改:

  • 考虑将文件类型过滤字符串的翻译与 setNameFilters 方法分开处理,以避免潜在的国际化问题。可以在用户界面初始化时进行翻译,然后将翻译后的字符串传递给 setNameFilters 方法。

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, ComixHe

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit 955b920 into linuxdeepin:master Apr 18, 2025
17 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants