Skip to content

feat: Support VERSION file#663

Merged
zccrs merged 2 commits intomasterfrom
version
Jun 11, 2025
Merged

feat: Support VERSION file#663
zccrs merged 2 commits intomasterfrom
version

Conversation

@asterwyx
Copy link
Contributor

@asterwyx asterwyx commented Jun 9, 2025

Use VERSION file to manage DTK version. VERSION file defines package version. It also decides the initial value of cached variable DTK_VERSION which controls the project version in cmake build system. VERSION file is not synchronized to DTK6, as DTK6 has its own VERSION file. One can still pass version to DTK_VERSION when running cmake configure. This is helpful for developers.

Signed-off-by: Yixue Wang wangyixue@deepin.org

asterwyx added 2 commits June 9, 2025 14:34
Use VERSION file to manage DTK version. VERSION file defines package version. It also decides the initial value of cached variable DTK_VERSION which controls the project version in cmake build system. VERSION file is not synchronized to DTK6, as DTK6 has its own VERSION file. One can still pass version to DTK_VERSION when running cmake configure. This is helpful for developers.

Signed-off-by: Yixue Wang <wangyixue@deepin.org>
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: asterwyx

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • .github/workflows/call-auto-release.yml文件中,workflow_dispatchworkflow_call的输入参数定义重复,可以提取为一个公共部分以提高代码复用性。
  • CMakeLists.txt文件中,使用file(READ)读取VERSION文件并去除空白字符来设置版本号,这是一个好的做法,可以避免版本号包含不必要的空格。

是否建议立即修改:

  • 是,建议立即修改重复的输入参数定义,以提高代码的可维护性。
  • 是,建议保持CMakeLists.txt中的版本号读取和处理逻辑,这是一个良好的实践。

deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Jun 9, 2025
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#663
@asterwyx asterwyx requested review from 18202781743 and zccrs June 9, 2025 06:49
@zccrs zccrs merged commit 9618f0c into master Jun 11, 2025
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants