feat: update window control icons and drawing logic#664
Merged
18202781743 merged 1 commit intolinuxdeepin:masterfrom Jun 18, 2025
Merged
feat: update window control icons and drawing logic#66418202781743 merged 1 commit intolinuxdeepin:masterfrom
18202781743 merged 1 commit intolinuxdeepin:masterfrom
Conversation
1. Replaced window_normal.dci with window_restore.dci and window_quit_full.dci icons 2. Updated icon references in dtk-icon-theme.qrc resource file 3. Simplified title bar button drawing functions to use new icons instead of manual drawing 4. Modified DStyle implementation to use the new icon assets 5. Improved visual consistency by using pre-made icons rather than programmatic drawing The changes were made to: - Standardize window control icons across the application - Replace programmatic drawing with higher quality vector icons - Make the UI more maintainable by using consistent icon assets - Prepare for future theme support by using icon resources feat: 更新窗口控制图标和绘制逻辑 1. 用 window_restore.dci 和 window_quit_full.dci 图标替换了 window_normal.dci 2. 更新了 dtk-icon-theme.qrc 资源文件中的图标引用 3. 简化了标题栏按钮绘制函数,使用新图标替代手动绘制 4. 修改了 DStyle 实现以使用新的图标资源 5. 通过使用预制图标而非程序绘制提高了视觉一致性 这些修改的目的是: - 标准化应用程序中的窗口控制图标 - 用更高质量的矢量图标替代程序绘制 - 通过使用一致的图标资源提高UI可维护性 - 通过使用图标资源为未来主题支持做准备
deepin-ci-robot
added a commit
to linuxdeepin/dtk6widget
that referenced
this pull request
Jun 18, 2025
Synchronize source files from linuxdeepin/dtkwidget. Source-pull-request: linuxdeepin/dtkwidget#664
Contributor
deepin pr auto review代码审查意见:
总体来说,这些更改看起来是为了更新图标和绘制逻辑,但需要确保这些更改是经过充分讨论和测试的,并且符合项目的需求和用户界面的预期。 |
mhduiy
approved these changes
Jun 18, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
18202781743
pushed a commit
to linuxdeepin/dtk6widget
that referenced
this pull request
Jun 18, 2025
Synchronize source files from linuxdeepin/dtkwidget. Source-pull-request: linuxdeepin/dtkwidget#664
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
window_quit_full.dci icons
instead of manual drawing
programmatic drawing
The changes were made to:
feat: 更新窗口控制图标和绘制逻辑
window_normal.dci
这些修改的目的是: