fix: remove DTK version mapping for unified build#720
Merged
18202781743 merged 1 commit intolinuxdeepin:masterfrom Jan 21, 2026
Merged
fix: remove DTK version mapping for unified build#72018202781743 merged 1 commit intolinuxdeepin:masterfrom
18202781743 merged 1 commit intolinuxdeepin:masterfrom
Conversation
Removed DTK5 and DTK6 version mapping logic from debian/rules file. The DTK5_VERSION, DTK6_VERSION, and DTK5_MAJOR_MINOR variables are no longer needed since DTK5 and DTK6 now use consistent version numbers. Also removed the override_dh_makeshlibs target that was using these version variables for setting shared library dependencies. This change is part of the DTK unified build transformation where DTK5 and DTK6 versions are now aligned, eliminating the need for separate version mapping logic. The build system can now use the same version numbers for both DTK5 and DTK6 components. Influence: 1. Verify that DTK5 and DTK6 packages build successfully without version mapping 2. Test that shared library dependencies are correctly handled without manual version overrides 3. Ensure build profiles (nodtk5, nodtk6) still work correctly 4. Check that documentation builds properly with BUILD_DOCS flag 5. Validate that both build5 and build6 directories are still properly cleaned fix: 移除DTK版本映射以实现统一构建 从debian/rules文件中移除了DTK5和DTK6版本映射逻辑。由于DTK5和DTK6现在使用 一致的版本号,不再需要DTK5_VERSION、DTK6_VERSION和DTK5_MAJOR_MINOR变量。 同时移除了使用这些版本变量设置共享库依赖的override_dh_makeshlibs目标。 此变更是DTK统一构建改造的一部分,DTK5和DTK6版本现已对齐,无需单独的版本 映射逻辑。构建系统现在可以为DTK5和DTK6组件使用相同的版本号。 Influence: 1. 验证DTK5和DTK6包在没有版本映射的情况下能成功构建 2. 测试共享库依赖在没有手动版本覆盖的情况下能正确处理 3. 确保构建配置文件(nodtk5、nodtk6)仍能正常工作 4. 检查文档构建是否仍能正确使用BUILD_DOCS标志 5. 验证build5和build6目录是否仍能被正确清理
Contributor
|
Warning
|
Contributor
deepin pr auto review这段代码是针对 以下是对该修改的审查意见,涵盖语法逻辑、代码质量、代码性能和代码安全四个方面: 1. 语法逻辑
2. 代码质量
3. 代码性能
4. 代码安全
总结与建议这段修改可能是正确的,前提是项目已经采用了更现代或更标准的 Debian 打包实践来替代被删除的逻辑。 关键检查点:
结论:如果项目已配置好符号文件( |
asterwyx
approved these changes
Jan 21, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, asterwyx The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed DTK5 and DTK6 version mapping logic from debian/rules file. The
DTK5_VERSION, DTK6_VERSION, and DTK5_MAJOR_MINOR variables are no longer
needed since DTK5 and DTK6 now use consistent version numbers. Also
removed the override_dh_makeshlibs target that was using these version
variables for setting shared library dependencies.
This change is part of the DTK unified build transformation where DTK5
and DTK6 versions are now aligned, eliminating the need for separate
version mapping logic. The build system can now use the same version
numbers for both DTK5 and DTK6 components.
Influence:
mapping
manual version overrides
cleaned
fix: 移除DTK版本映射以实现统一构建
从debian/rules文件中移除了DTK5和DTK6版本映射逻辑。由于DTK5和DTK6现在使用
一致的版本号,不再需要DTK5_VERSION、DTK6_VERSION和DTK5_MAJOR_MINOR变量。
同时移除了使用这些版本变量设置共享库依赖的override_dh_makeshlibs目标。
此变更是DTK统一构建改造的一部分,DTK5和DTK6版本现已对齐,无需单独的版本
映射逻辑。构建系统现在可以为DTK5和DTK6组件使用相同的版本号。
Influence: