Skip to content

fix: Fix build with Qt 6.10.2#726

Merged
18202781743 merged 1 commit intolinuxdeepin:masterfrom
hillwoodroc:master
Feb 5, 2026
Merged

fix: Fix build with Qt 6.10.2#726
18202781743 merged 1 commit intolinuxdeepin:masterfrom
hillwoodroc:master

Conversation

@hillwoodroc
Copy link
Contributor

Qt 6.10.2 removed QTabBarPrivate::paintWithOffsets, causing build failures in DTabBar.

Adjust tab button positioning logic to rely solely on dragOffset for Qt >= 6.10.2, while preserving the original behavior for older Qt versions.

This aligns the implementation with the updated QTabBar internals and restores compatibility with Qt 6.10.2.

Qt 6.10.2 removed QTabBarPrivate::paintWithOffsets, causing
build failures in DTabBar.

Adjust tab button positioning logic to rely solely on
dragOffset for Qt >= 6.10.2, while preserving the original
behavior for older Qt versions.

This aligns the implementation with the updated QTabBar
internals and restores compatibility with Qt 6.10.2.
@deepin-ci-robot
Copy link
Contributor

Hi @hillwoodroc. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BLumia BLumia requested a review from 18202781743 February 4, 2026 14:39
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, hillwoodroc

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit 561141f into linuxdeepin:master Feb 5, 2026
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants