-
Notifications
You must be signed in to change notification settings - Fork 41
fix: add cursor size listener and optimize cursor theme handling #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Synchronize source files from linuxdeepin/qt5platform-plugins. Source-pull-request: linuxdeepin/qt5platform-plugins#311
Synchronize source files from linuxdeepin/qt5platform-plugins. Source-pull-request: linuxdeepin/qt5platform-plugins#311
Synchronize source files from linuxdeepin/qt5platform-plugins. Source-pull-request: linuxdeepin/qt5platform-plugins#311
Synchronize source files from linuxdeepin/qt5platform-plugins. Source-pull-request: linuxdeepin/qt5platform-plugins#311
deepin pr auto review我来对这个 diff 进行详细审查:
总体来说,这个修改解决了实际问题,代码质量较好,但还有一些可以优化的地方。建议在后续版本中考虑这些改进建议。 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1. Added cursor theme size property listener alongside existing cursor theme name listener 2. Modified cursorThemePropertyChanged function to directly handle cursor updates instead of queued invocation 3. Added explicit cursor cache clearing and context reinitialization for all screens 4. Removed queued connection to ensure immediate cursor updates when theme properties change The changes address the need for real-time cursor updates when both cursor theme name and size change. Previously, only theme name changes were monitored, and cursor updates were queued which could cause delays. Now the function directly clears cursor caches, reinitializes cursor contexts, and updates all window cursors immediately. This ensures consistent cursor appearance across all windows when theme properties are modified. Log: Added cursor theme size change listener for real-time cursor updates Influence: 1. Test cursor theme changes by modifying both theme name and size settings 2. Verify cursor updates immediately across all application windows 3. Test with multiple screens to ensure proper cursor context reinitialization 4. Verify cursor cache is properly cleared when theme properties change 5. Test application behavior during theme property changes to ensure no crashes or memory leaks fix: 增加光标大小监听并优化光标主题处理 1. 在现有光标主题名称监听的基础上,新增光标主题大小属性监听 2. 修改cursorThemePropertyChanged函数,直接处理光标更新而非排队调用 3. 为所有屏幕添加显式的光标缓存清理和上下文重新初始化 4. 移除排队连接,确保主题属性变化时立即更新光标 这些更改解决了光标主题名称和大小变化时需要实时更新光标的问题。之前仅监听 了主题名称变化,且光标更新被排队处理可能导致延迟。现在函数直接清理光标缓 存、重新初始化光标上下文并立即更新所有窗口光标。这确保了主题属性修改时所 有窗口的光标外观保持一致。 Log: 新增光标主题大小变化监听,实现实时光标更新 Influence: 1. 测试修改主题名称和大小设置时的光标变化 2. 验证所有应用程序窗口的光标立即更新 3. 使用多屏幕测试,确保正确重新初始化光标上下文 4. 验证主题属性变化时正确清理光标缓存 5. 测试主题属性变化期间的应用程序行为,确保无崩溃或内存泄漏 pms: STORY-39797
Synchronize source files from linuxdeepin/qt5platform-plugins. Source-pull-request: linuxdeepin/qt5platform-plugins#311
|
/forcemerge |
|
This pr force merged! (status: unstable) |
Synchronize source files from linuxdeepin/qt5platform-plugins. Source-pull-request: linuxdeepin/qt5platform-plugins#311
The changes address the need for real-time cursor updates when both cursor theme name and size change. Previously, only theme name changes were monitored, and cursor updates were queued which could cause delays. Now the function directly clears cursor caches, reinitializes cursor contexts, and updates all window cursors immediately. This ensures consistent cursor appearance across all windows when theme properties are modified.
Log: Added cursor theme size change listener for real-time cursor updates
Influence:
fix: 增加光标大小监听并优化光标主题处理
这些更改解决了光标主题名称和大小变化时需要实时更新光标的问题。之前仅监听
了主题名称变化,且光标更新被排队处理可能导致延迟。现在函数直接清理光标缓
存、重新初始化光标上下文并立即更新所有窗口光标。这确保了主题属性修改时所
有窗口的光标外观保持一致。
Log: 新增光标主题大小变化监听,实现实时光标更新
Influence: