Skip to content

Conversation

@amolsontakke3576
Copy link
Contributor

This pull request introduces changes to enhance error handling and add a new property to the OrganizationModel. The most significant updates include adding an isSanctioned property to the organization model, implementing a new error modal in the corporate dashboard, and updating the logic to handle restricted organizations.

Enhancements to Error Handling:

  • New Error Modal in Corporate Dashboard:
    • Added an errorModal template in corporate-dashboard.component.html to display a message when a restricted organization is detected.
    • Registered the errorModal template in the CorporateDashboardComponent class using @ViewChild.
    • Updated the organization fetch logic to check the isSanctioned property. If the organization is restricted, the error modal is displayed with a relevant message.

Updates to Organization Model:

  • New Property isSanctioned:
    • Added an isSanctioned property to the OrganizationModel to indicate whether an organization is restricted.

Screenshot from 2025-05-08 13-26-29

Signed-off-by: Amol Sontakke <[email protected]>
lukaszgryglicki
lukaszgryglicki previously approved these changes May 8, 2025
Copy link
Member

@lukaszgryglicki lukaszgryglicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: Amol Sontakke <[email protected]>
@mlehotskylf
Copy link
Contributor

@amolsontakke3576 it look ok, just please do couple changes.

Message should be:
We're sorry, you're currently unable to acknowledge the Employee Contributor License Agreement (ECLA).
If you believe this is an error, please contact EasyCLA Support.

Please also remove that big exclamation mark and "Restricted Organization". We don't want to scare anyone :-)

Screenshot 2025-05-08 at 11 36 49 PM

Signed-off-by: Amol Sontakke <[email protected]>
Signed-off-by: Amol Sontakke <[email protected]>
@amolsontakke3576
Copy link
Contributor Author

Here is updated modal
Screenshot from 2025-05-09 13-03-29

Copy link
Member

@lukaszgryglicki lukaszgryglicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@amolsontakke3576 amolsontakke3576 merged commit 864b085 into main May 14, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants