GitHub Login test #444
Merged
GitHub Login test #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amol Sontakke <[email protected]>
Signed-off-by: Amol Sontakke <[email protected]>
amolsontakke3576
requested review from
lukaszgryglicki,
mlehotskylf and
thakurveerendras
| }, | ||
| { | ||
| path: 'cla/project/:projectId/user/:userId', | ||
| path: 'cla/project/:projectId', |
Member
There was a problem hiding this comment.
Please do not remove the old route which is our default route for almost all flows.
You should add a new route (without uuid) instead and for that route you should call /v2/user-from-session API and when you get user UUID from that API - redirect back to "old" route with that user UUID just returned from api, so:
On cla/project/:projectId call /v2/user-from-session to get user. Get this user's UUID and route to cla/project/:projectId/user/:userId. cc @thakurveerendras @amolsontakke3576 @mlehotskylf
| import { ClaContributorService } from 'src/app/core/services/cla-contributor.service'; | ||
| import { ProjectModel } from 'src/app/core/models/project'; | ||
| import { UserModel } from 'src/app/core/models/user'; | ||
| import { UserFromSessionModel, UserFromTokenModel } from 'src/app/core/models/user'; |
Member
There was a problem hiding this comment.
Similar here - I think you need to add two new models but don't remove the already exiting one...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.