-
Notifications
You must be signed in to change notification settings - Fork 9
refactor: get auth0 dev details for local test #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Amol Sontakke <[email protected]>
WalkthroughA console log statement was added to the Changes
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
lukaszgryglicki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/app/shared/services/auth.service.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
| // Need to increase timeout to 1500 as for slower network it gives an error | ||
| // Cannot read property 'querySelector' of null | ||
| // TODO: verify this still works | ||
| console.log('login details', EnvConfig.default['auth0-clientId'], EnvConfig.default['auth0-clientSecret'], EnvConfig.default['auth0-domain']); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove logging of sensitive credentials
Logging auth0-clientSecret exposes a secret in client‐side logs and poses a serious security risk. Remove this log or at minimum strip out the secret and gate any remaining output behind a development-only flag.
Proposed diff:
- console.log('login details', EnvConfig.default['auth0-clientId'], EnvConfig.default['auth0-clientSecret'], EnvConfig.default['auth0-domain']);
+ // Log only non-sensitive values in development mode
+ import { environment } from 'src/environments/environment';
+
+ if (!environment.production) {
+ console.log('Auth0 config:', {
+ clientId: EnvConfig.default['auth0-clientId'],
+ domain: EnvConfig.default['auth0-domain']
+ });
+ }Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In src/app/shared/services/auth.service.ts at line 131, remove the console.log
statement that outputs sensitive credentials including auth0-clientSecret to
prevent exposing secrets in client-side logs. If logging is necessary, ensure it
only runs in development mode and exclude any secret values from the output.
Summary by CodeRabbit