-
Notifications
You must be signed in to change notification settings - Fork 9
Switch to new api '/v4/project-compat/<uuid>' instead of '/v2/project/<uuid>' #450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to new api '/v4/project-compat/<uuid>' instead of '/v2/project/<uuid>' #450
Conversation
…/<uuid>' Signed-off-by: Łukasz Gryglicki <[email protected]>
WalkthroughThe API endpoint URLs used in the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/app/core/services/cla-contributor.service.ts(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (1)
src/app/core/services/cla-contributor.service.ts (1)
68-71: API endpoint migration approved — verify endpoint availabilityMigration from v2 to v4 (
/v4/project-compat/:projectId) is implemented correctly:
- No remaining
v2/projectreferences found in the codebase.- Both
getProjectandgetGerritProjectInfopreserve their original signatures and return types.Before deploying, please verify:
- The dependent PR (linuxfoundation/easycla#4711) has been merged and deployed.
- The v4 endpoint (
/v4/project-compat/:projectId) returns data compatible withProjectModel.
Signed-off-by: Łukasz Gryglicki <[email protected]>
|
@amolsontakke3576 sorry - can you TAL again - I've updated |
|
Thanks, will merge when |
cc @mlehotskylf @amolsontakke3576 @thakurveerendras - this can only be merged into
devafter linuxfoundation/easycla#4711 is merged & deployed.Then it needs testing.
Once completed - 1st API porting from
pythontogolangwill be complete.Summary by CodeRabbit