-
Notifications
You must be signed in to change notification settings - Fork 9
Update README.md #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #454
Conversation
Updated readme file
WalkthroughThe README.md file was updated to include comprehensive instructions for setting up, installing, building, and running the project locally. New sections cover prerequisites, installation steps, build commands, local server usage, troubleshooting, and an example local URL for testing. Changes
Estimated code review effort1 (~2 minutes) Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
lukaszgryglicki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (3)
README.md (3)
36-38: Drop leading$prompts to satisfy markdownlint MD014 (commands-show-output).Markdown-lint flags the dollar prompt when no command output is shown. Removing the prompt keeps the snippet valid and copy-pastable.
-```bash -$ npm install -g yarn +```bash +npm install -g yarn @@ -```bash -$ npm install -g @angular/cli +```bash +npm install -g @angular/cli @@ -```bash -$ yarn install +```bash +yarn installAlso applies to: 42-44, 50-52
67-68: Malformed sample URL & bare-URL lint error (MD034).The inline code fence opens with a back-tick but never closes, and the bare URL will fail markdownlint. Close the code span and/or convert to a markdown link:
-`http://localhost:8100/#/cla/project/projectId/user/userId?redirect=URL +<http://localhost:8100/#/cla/project/<projectId>/user/<userId>?redirect=<redirectURL>>Wrap variable segments in angle-brackets (or back-ticks) for clarity.
33-34: Minor wording refinement for clarity.-1. Make sure you have Node 12.x or higher, together with NPM 6.x or higher. +1. Ensure you have Node 12.20 (or newer) and npm 6 (or newer) installed.This tightens phrasing and specifies the minimum Node version officially required by Angular 13+.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md(1 hunks)
🪛 markdownlint-cli2 (0.17.2)
README.md
37-37: Dollar signs used before commands without showing output
(MD014, commands-show-output)
43-43: Dollar signs used before commands without showing output
(MD014, commands-show-output)
51-51: Dollar signs used before commands without showing output
(MD014, commands-show-output)
67-67: Bare URL used
(MD034, no-bare-urls)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
37-37: Dollar signs used before commands without showing output
(MD014, commands-show-output)
43-43: Dollar signs used before commands without showing output
(MD014, commands-show-output)
51-51: Dollar signs used before commands without showing output
(MD014, commands-show-output)
67-67: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (1)
README.md (1)
61-64: Confirm the existence of theservescript and HTTPS setup.
yarn serveonly works if a"serve"script exists inpackage.json; Angular CLI’s default isng serve. In addition,https://localhost:8100requires the dev server to be started with the--sslflag or custom configuration.Please verify:
package.jsonincludes"scripts": { "serve": "ng serve --ssl true --port 8100" }- The instructions (and sample URL) match the actual protocol (
httporhttps).
Signed-off-by: Amol Sontakke <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
♻️ Duplicate comments (1)
README.md (1)
40-44: Package name still incorrect in the bullet text – stick to@angular/cli.The narrative line still mentions
angular-cli, which was deprecated years ago.
Your code block is right, but the bullet is misleading and will trip people up.-3. Install `angular-cli` globally. (version 11). +3. Install `@angular/cli` globally (version 13 or higher).
🧹 Nitpick comments (2)
README.md (2)
36-38: Strip the$prompt to satisfy MD014 or show expected output.markdownlint is flagging
MD014because the commands include a leading$but no
captured output. Either remove the prompt or add sample output below each
command. Example fix:-```bash -$ npm install -g yarn -``` +```bash +npm install -g yarn +```Also applies to: 42-44, 50-52
61-63: Add a Windows-friendly alternative for the OpenSSL flag.
export NODE_OPTIONS=--openssl-legacy-provideronly works on Unix shells.
Consider adding the PowerShell / CMD variant so Windows contributors aren’t
blocked.# PowerShell setx NODE_OPTIONS "--openssl-legacy-provider"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md(1 hunks)
🪛 markdownlint-cli2 (0.17.2)
README.md
37-37: Dollar signs used before commands without showing output
(MD014, commands-show-output)
43-43: Dollar signs used before commands without showing output
(MD014, commands-show-output)
51-51: Dollar signs used before commands without showing output
(MD014, commands-show-output)
67-67: Bare URL used
(MD034, no-bare-urls)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
37-37: Dollar signs used before commands without showing output
(MD014, commands-show-output)
43-43: Dollar signs used before commands without showing output
(MD014, commands-show-output)
51-51: Dollar signs used before commands without showing output
(MD014, commands-show-output)
67-67: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
| ## Sample Local URL | ||
| `http://localhost:8100/#/cla/project/projectId/user/userId?redirect=URL | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unterminated back-tick breaks the rest of the document.
There’s an opening back-tick but no closing delimiter, causing Markdown to treat
the remainder of the file as code.
-`http://localhost:8100/#/cla/project/projectId/user/userId?redirect=URL
+```text
+http://localhost:8100/#/cla/project/projectId/user/userId?redirect=URL
+```🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
67-67: Bare URL used
(MD034, no-bare-urls)
🤖 Prompt for AI Agents
In README.md around lines 66 to 68, the Markdown code block for the sample local
URL is missing a closing back-tick, causing the rest of the document to be
treated as code. Add a closing back-tick at the end of the URL line to properly
terminate the inline code block.
This pull request updates the
README.mdfile to include detailed setup, installation, and usage instructions for the project. These changes aim to make it easier for developers to get started with the project locally.Documentation Enhancements:
yarnandangular-cli.yarn.Summary by CodeRabbit