Skip to content

Feature: added cookies concent#49

Merged
amolsontakke3576 merged 2 commits intomainfrom
feature/cookies-concent
Jun 24, 2025
Merged

Feature: added cookies concent#49
amolsontakke3576 merged 2 commits intomainfrom
feature/cookies-concent

Conversation

@amolsontakke3576
Copy link
Contributor

@amolsontakke3576 amolsontakke3576 commented Jun 23, 2025

This pull request updates dependencies in the package.json file and modifies the src/app/app.component.html file to enhance functionality. The most notable changes include updating the @linuxfoundation/lfx-ui-core library version, specifying the package manager, and adding cookie tracking to the footer component.

Dependency Updates:

  • package.json: Updated the @linuxfoundation/lfx-ui-core library from version ^0.0.12 to ^0.0.18 to include the latest features and fixes.
  • package.json: Added the packageManager field with the value "yarn@1.22.21+sha1.1959a18351b811cdeedbd484a8f86c3cc3bbaf72" to explicitly specify the package manager being used.

Functional Enhancements:

  • src/app/app.component.html: Updated the <lfx-footer> component to include cookie-tracking="true", enabling cookie tracking functionality.

Screenshot from 2025-06-23 20-52-20

Summary by CodeRabbit

  • New Features

    • Enabled cookie tracking functionality in the site footer.
  • Chores

    • Updated a core UI dependency to the latest version.

Signed-off-by: Amol Sontakke <amols@proximabiz.com>
Signed-off-by: Amol Sontakke <amols@proximabiz.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR titles must follow Conventional Commits. Love from, Your reviewers ❤️.

@coderabbitai
Copy link

coderabbitai bot commented Jun 23, 2025

Walkthrough

The dependency "@linuxfoundation/lfx-ui-core" was updated from version "^0.0.12" to "^0.0.18" in the package configuration. Additionally, the <lfx-footer> component in the main application HTML was modified to include the cookie-tracking="true" attribute, enabling cookie tracking functionality.

Changes

File(s) Change Summary
package.json Updated "@linuxfoundation/lfx-ui-core" from "^0.0.12" to "^0.0.18".
src/app/app.component.html Added cookie-tracking="true" to <lfx-footer>.

Poem

A hop and a skip, a version anew,
The footer now tracks cookies for you.
With dependencies fresh, and features in tow,
The app keeps on growing, as all bunnies know!
🐇✨


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@amolsontakke3576 amolsontakke3576 changed the title Feature/cookies concent Feature: added cookies concent Jun 23, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/app/app.component.html (1)

16-16: Confirm cookie-tracking attribute compatibility and add tests.
Make sure the upgraded <lfx-footer> in ^0.0.18 actually supports a cookieTracking input binding. It’d be helpful to add a unit or end-to-end test to verify that cookie consent tracking is enabled when this attribute is set.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0032520 and e58412e.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • package.json (1 hunks)
  • src/app/app.component.html (1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Snyk Scan NPM Landing Page Dependencies
package.json

[error] 1-1: Snyk authentication error (SNYK-0005): Authentication credentials not recognized or user access not provisioned. Status 401 Unauthorized.

🔇 Additional comments (2)
package.json (2)

1-9: Verify presence of packageManager field.
The PR objectives mention adding a packageManager entry ("yarn@1.22.21+sha1.1959a18351b811cdeedbd484a8f86c3cc3bbaf72") to this file, but it's not present. Please confirm whether this field was intended to be committed.


50-50: Verify dependency upgrade to ^0.0.18.
Ensure that bumping @linuxfoundation/lfx-ui-core to ^0.0.18 is fully compatible: regenerate/commit your lockfile (yarn.lock), run the full test suite, and review the library’s changelog for any breaking changes.

@amolsontakke3576 amolsontakke3576 merged commit feb62f7 into main Jun 24, 2025
9 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants