feat: update lfx-ui-core to v0.1.0 and add cookie consent to footer #77
Conversation
- Update @linuxfoundation/lfx-ui-core from 0.0.19 to 0.1.0 - Add cookie-tracking attribute to lfx-footer component for cookie consent integration - Cookie consent uses base Osano script URL without variant parameter Addresses: UIARCH-106
WalkthroughThis PR upgrades the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.cursor/commands/update-lfx-ui-core.md (1)
7-7: Format the URL as a proper Markdown link.The bare URL triggers a markdownlint warning. Consider formatting it as a proper Markdown link for better readability and compliance with markdown standards.
🔎 Proposed fix
-https://github.com/linuxfoundation/lfx-ui/blob/main/docs/footer.md#cookie-consent-integration +[LFX UI Footer Documentation - Cookie Consent Integration](https://github.com/linuxfoundation/lfx-ui/blob/main/docs/footer.md#cookie-consent-integration)
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (3)
.cursor/commands/update-lfx-ui-core.md(1 hunks)package.json(2 hunks)src/app/components/cla-footer/cla-footer.component.html(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
.cursor/commands/update-lfx-ui-core.md
7-7: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Agent
🔇 Additional comments (3)
package.json (2)
102-102: Clarify the packageManager field addition.The addition of the
packageManagerfield enforces Yarn v1.22.22 via Corepack. This change is not mentioned in the PR objectives or summary. Can you confirm this addition is intentional and not an accidental commit from your local environment configuration?
50-50: Version v0.1.0 of @linuxfoundation/lfx-ui-core has not been released yet.The upgrade references v0.1.0, but the latest published version is 0.0.15. Before upgrading to v0.1.0, ensure the version is officially released on npm and review the changelog for any breaking changes.
src/app/components/cla-footer/cla-footer.component.html (1)
5-5: The package version appears to be incorrect. The latest version of @linuxfoundation/lfx-ui-core is 0.0.15, not 0.1.0 as referenced. Verify the actual package version being used and consult the corresponding library documentation for the correctcookie-trackingattribute syntax.
There was a problem hiding this comment.
Pull request overview
This PR updates the LFX UI Core library to version 0.1.0 and integrates cookie consent functionality into the footer component by adding the cookie-tracking attribute.
- Updated
@linuxfoundation/lfx-ui-coredependency from version 0.0.19 to 0.1.0 - Added
cookie-trackingattribute to the<lfx-footer>component for Osano cookie consent integration - Added
packageManagerfield to package.json for yarn version pinning
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updates lfx-ui-core dependency to v0.1.0 and adds packageManager field for yarn version specification |
| yarn.lock | Updates lock file entries for the new lfx-ui-core version with corresponding integrity hash |
| src/app/components/cla-footer/cla-footer.component.html | Adds cookie-tracking attribute to lfx-footer component to enable cookie consent banner |
| .cursor/commands/update-lfx-ui-core.md | Adds documentation explaining the update rationale and implementation details |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ~ Copyright The Linux Foundation and each contributor to CommunityBridge. | ||
| ~ SPDX-License-Identifier: MIT | ||
| --> | ||
| <lfx-footer cookie-tracking></lfx-footer> |
There was a problem hiding this comment.
The cookie-tracking attribute is used inconsistently across the application. In app.component.html, it's set as cookie-tracking="true" (with an explicit value), while here it's used as a boolean attribute without a value. For consistency and clarity, these should use the same format throughout the codebase. Consider using cookie-tracking="true" to match the existing usage in app.component.html.
| <lfx-footer cookie-tracking></lfx-footer> | |
| <lfx-footer cookie-tracking="true"></lfx-footer> |
Summary
Updates @linuxfoundation/lfx-ui-core to the latest version (0.1.0) and adds cookie consent integration to the footer component.
Changes
@linuxfoundation/lfx-ui-corefrom0.0.19to0.1.0cookie-trackingattribute to<lfx-footer>component for cookie consent integrationReference
Testing