API ported - address lint

Signed-off-by: Lukasz Gryglicki <[email protected]>

Author: lukaszgryglicki

cla-backend-go/swagger/cla.v2.yaml

@@ -2458,12 +2458,12 @@ paths:
       summary: |
         Returns all metadata associated with a user's active signature.
         {
-          'user_id': <user-id>,
-          'project_id': <project-id>,
-          'repository_id': <repository-id>,
-          'pull_request_id': <PR>,
-          *'merge_request_id': <MR> (optional),
-          'return_url': <url-where-user-initiated-signature-from>'
+          'user_id': <user-uuid>,
+          'project_id': <project-uuid>,
+          'repository_id': <repository-id> (as string),
+          'pull_request_id': <PR> (PR number as string),
+          *'merge_request_id': <MR> (optional MR number as string - this property can be missing in JSON),
+          'return_url': <url-where-user-initiated-signature-from> (for example itHub PR path)'
         }
         Returns null if the user does not have an active signature.
       security: [ ]

cla-backend-go/swagger/common/user-active-signature.yaml

@@ -10,25 +10,25 @@ description: >
 properties:
   user_id:
     $ref: './common/properties/internal-id.yaml'
-    description: The unique internal ID of the user
+    description: The unique internal UUID of the user
   project_id:
     $ref: './common/properties/internal-id.yaml'
-    description: The unique ID of the associated project
+    description: The unique UUID of the associated project
   repository_id:
     type: string
-    description: The unique ID of the associated repository
+    description: The unique ID of the associated repository (number stored as string)
     example: '168926425'
   pull_request_id:
     type: string
-    description: The pull request ID related to the signature
+    description: The pull request ID related to the signature (number stored as string)
     example: '456'
   merge_request_id:
     type: string
-    description: The merge request ID related to the signature
+    description: The merge request ID related to the signature (optional number stored as string, thsi property can be missing in JSON)
     example: '456'
     x-nullable: true
   return_url:
     type: string
     format: uri
-    description: The return URL where the user initiated the signature
-    example: https://example.com/return
+    description: The return URL where the user initiated the signature (for example GitHub PR path)
+    example: https://github.com/veer-missingid2/repo03/pull/3

cla-backend-go/v2/sign/handlers.go

@@ -271,7 +271,9 @@ func Configure(api *operations.EasyclaAPI, service Service, userService users.Se
 				return middleware.ResponderFunc(func(w http.ResponseWriter, _ runtime.Producer) {
 					w.Header().Set("Content-Type", "application/json")
 					w.WriteHeader(http.StatusOK)
-					_, _ = w.Write([]byte("null"))
+					if _, err := w.Write([]byte("null")); err != nil {
+						log.WithFields(f).WithError(err).Warn("failed to write null response")
+					}
 				})
 			}
 			return sign.NewGetUserActiveSignatureOK().WithPayload(resp)

cla-backend-go/v2/sign/service.go

@@ -2852,10 +2852,10 @@ func (s *service) GetUserActiveSignature(ctx context.Context, userID string) (*m
 		log.WithFields(f).WithError(err).Warnf("unable to get active signature meta data for user: %s", userID)
 		return nil, err
 	}
+	log.WithFields(f).Debugf("active signature metadata: %+v", activeSignatureMetadata)
 	if len(activeSignatureMetadata) == 0 {
 		return nil, nil
 	}
-	log.WithFields(f).Debugf("active signature metadata: %+v", activeSignatureMetadata)
 	var (
 		mergeRequestId *string
 		isGitlab       bool

cla-backend/cla/routes.py

@@ -232,7 +232,7 @@ def request_company_ccla(
 #     return cla.controllers.user.request_company_admin_access(str(user_id), str(company_id))
 
 
-# LG: porting this to golang
+# LG: This is ported to golang and no longer used in dev (still used in prod)
 @hug.get("/user/{user_id}/active-signature", versions=2)
 def get_user_active_signature(user_id: hug.types.uuid):
     """