Skip to content

Comments

Update finding by github username prod (step 4)#4758

Merged
lukaszgryglicki merged 8 commits intomainfrom
dev
Aug 21, 2025
Merged

Update finding by github username prod (step 4)#4758
lukaszgryglicki merged 8 commits intomainfrom
dev

Conversation

@lukaszgryglicki
Copy link
Member

cc @mlehotskylf @ahmedomosanya

Assisted by OpenAI

Assisted by GitHub Copilot

Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>

Generated with [OpenAI](https://platform.openai.com/)
Assisted by [OpenAI](https://platform.openai.com/)
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>

Generated with [OpenAI](https://platform.openai.com/)
Assisted by [OpenAI](https://platform.openai.com/)
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>

Assisted by [OpenAI](https://platform.openai.com/)
Assisted by [GitHub Copilot](https://github.com/features/copilot)
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>

Assisted by [OpenAI](https://platform.openai.com/)
Assisted by [GitHub Copilot](https://github.com/features/copilot)
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>

Assisted by [OpenAI](https://platform.openai.com/)
Assisted by [GitHub Copilot](https://github.com/features/copilot)
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io>

Assisted by [OpenAI](https://platform.openai.com/)

Assisted by [GitHub Copilot](https://github.com/features/copilot)
…te-finding-by-username

Update finding by github username (step 4)
@lukaszgryglicki lukaszgryglicki self-assigned this Aug 21, 2025
Copilot AI review requested due to automatic review settings August 21, 2025 10:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds validation for GitHub usernames before attempting to lookup users by login name. The changes introduce a validation function to check if a name conforms to GitHub's username requirements (3-39 characters, alphanumeric and hyphens only, no leading/trailing hyphens, no consecutive hyphens) before making API calls.

  • Adds GitHub username validation regex patterns in both Python and Go backends
  • Implements validation functions to check username format before API lookups
  • Updates documentation to clarify co-author resolution process
  • Refactors AWS log analysis utilities for better modularity

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
cla-backend/cla/models/github_models.py Adds GitHub username regex pattern and validation function
cla-backend-go/github/github_repository.go Implements GitHub username validation in Go
CO_AUTHORS.md Updates documentation with validation details and troubleshooting
utils/count_apis.sh New utility script for counting API usage patterns
utils/calculate_api_stats.sh New script for calculating API statistics across regions
utils/search_aws_logs.sh Refactors to use new count_apis.sh utility
utils/search_aws_log_group.sh Adds example usage comments
tests/functional/README.md Adds SSH-compatible test running command

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@lukaszgryglicki lukaszgryglicki merged commit 09bd1c9 into main Aug 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants