Update finding by github username prod (step 4)#4758
Merged
lukaszgryglicki merged 8 commits intomainfrom Aug 21, 2025
Merged
Conversation
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io> Generated with [OpenAI](https://platform.openai.com/) Assisted by [OpenAI](https://platform.openai.com/)
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io> Generated with [OpenAI](https://platform.openai.com/) Assisted by [OpenAI](https://platform.openai.com/)
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot)
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot)
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot)
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot)
…te-finding-by-username Update finding by github username (step 4)
ahmedomosanya
approved these changes
Aug 21, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds validation for GitHub usernames before attempting to lookup users by login name. The changes introduce a validation function to check if a name conforms to GitHub's username requirements (3-39 characters, alphanumeric and hyphens only, no leading/trailing hyphens, no consecutive hyphens) before making API calls.
- Adds GitHub username validation regex patterns in both Python and Go backends
- Implements validation functions to check username format before API lookups
- Updates documentation to clarify co-author resolution process
- Refactors AWS log analysis utilities for better modularity
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| cla-backend/cla/models/github_models.py | Adds GitHub username regex pattern and validation function |
| cla-backend-go/github/github_repository.go | Implements GitHub username validation in Go |
| CO_AUTHORS.md | Updates documentation with validation details and troubleshooting |
| utils/count_apis.sh | New utility script for counting API usage patterns |
| utils/calculate_api_stats.sh | New script for calculating API statistics across regions |
| utils/search_aws_logs.sh | Refactors to use new count_apis.sh utility |
| utils/search_aws_log_group.sh | Adds example usage comments |
| tests/functional/README.md | Adds SSH-compatible test running command |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @mlehotskylf @ahmedomosanya
Assisted by OpenAI
Assisted by GitHub Copilot