Unicron 4759 fix missing installation id prod#4770
Merged
lukaszgryglicki merged 3 commits intomainfrom Aug 26, 2025
Merged
Conversation
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot)
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes missing installation ID issues in production by enhancing the GitHub installation event handling logic and improving co-author detection for CLA checks. The changes include better user lookup mechanisms, improved error handling, and additional tracking for missing co-authors.
- Added installation ID validation and better error handling for GitHub webhook events
- Enhanced co-author detection with additional database lookups and missing co-author tracking
- Improved user search performance with new LF email index and optimized query methods
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| utils/search_aws_log_group.sh | Added validation for timestamp parameters to prevent invalid date parsing |
| utils/count_apis.sh | Enhanced API counting with additional regex patterns for LF IDs and null values |
| cla-backend/cla/utils.py | Added missing co-author message template and updated comment generation to track missing co-authors |
| cla-backend/cla/models/model_interfaces.py | Added new interface methods for faster user lookups by email |
| cla-backend/cla/models/github_models.py | Enhanced co-author detection with database fallback lookups and missing co-author tracking |
| cla-backend/cla/models/dynamo_models.py | Added LF email index for faster user queries and improved null value handling |
| cla-backend/cla/controllers/user.py | Updated to use faster email lookup method |
| cla-backend/cla/controllers/github.py | Improved GitHub installation event handling with better error handling and installation ID validation |
| cla-backend-go/v2/signatures/mock_users/mock_service.go | Added mock methods for new user lookup services |
| cla-backend-go/v2/sign/helpers.go | Updated to handle missing co-author tracking in pull request processing |
| cla-backend-go/users/service.go | Added new service methods for user lookups by email and LF email |
| cla-backend-go/users/repository.go | Implemented new repository methods for LF email queries with proper case handling |
| cla-backend-go/users/mocks/mock_repo.go | Added mock method for LF email user lookup |
| cla-backend-go/signatures/service.go | Updated signature service to handle missing co-author tracking |
| cla-backend-go/github/github_repository.go | Enhanced co-author processing with database fallback and missing co-author message support |
| CO_AUTHORS.md | Updated documentation to reflect new database lookup fallback for co-authors |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot)
Signed-off-by: Lukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot)
ahmedomosanya
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4759 cc @mlehotskylf @jarias-lfx @ahmedomosanya
Signed-off-by: Lukasz Gryglicki lgryglicki@cncf.io
Assisted by OpenAI
Assisted by GitHub Copilot