fix(easycla): document headless hand-off open and rename sealed test

[ahmedomosanya]

Follow-up to #2344 (own ccla hand-off heading in the child): add the lens-switcher showHeader / ariaLabelledBy / contentStyle comments on the CCLA hand-off open, and rename the sealed-state spec to the in-content close control.

Refs #2344

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Essentials

Run ID: be2e4153-cddb-434a-a91b-ba0c006a686f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[cursor]

PR Summary

Low Risk
Comment-only dialog config documentation and a test title rename; no logic or config value changes.

Overview
Follow-up to the headless CCLA sign hand-off dialog (#2344): no runtime behavior change in this PR.

openHandOff in org-easycla-detail.component.ts now has inline comments on the existing PrimeNG DynamicDialog options—showHeader: false (body supplies the title), ariaLabelledBy pointing at the hand-off component’s in-content <h2>, and contentStyle padding to replace the top spacing the removed header used to provide.

The hand-off spec renames one test from dismissing via a header control to the in-content close control while preparing, matching the UI after the PrimeNG header was removed.

^{Reviewed by Cursor Bugbot for commit e19f32d. Bugbot is set up for automated code reviews on this repo. Configure here.}

[Copilot]

Pull request overview

Documents the headless CCLA hand-off dialog configuration and aligns the sealed-state test name with the actual close control.

Changes:

• Explains dialog heading, accessibility labeling, and padding configuration.
• Renames the preparation-state test for accuracy.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
org-easycla-sign-handoff.component.spec.ts	Clarifies the tested close-control behavior.
org-easycla-detail.component.ts	Documents headless dialog configuration.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[dealako]

@ahmedomosanya — thanks for the follow-up to #2344. This is a tight, comment-only patch that documents the headless hand-off dialog config and renames the sealed-state spec to match the in-content close control. The showHeader and contentStyle comments are accurate and consistent with the lens-switcher precedent; the spec rename is correct.

One issue blocks merge: the new ariaLabelledBy comment describes behavior PrimeNG 20.4.0 does not implement, which is especially problematic because this PR's only product is documentation.

Issue count

• 🔴 Blocking: 1 issue: ariaLabelledBy comment claims the config names the dialog, but DynamicDialogConfig.ariaLabelledBy is never forwarded to <p-dialog> in PrimeNG 20.4.0
• 🟡 Minor: 0 issues
• ⚪ Nit: 0 issues
• ❔ Question: 0 items

Bot reconciliation

• CodeRabbit — review skipped (auto-reviews disabled); no findings to reconcile.
• Cursor Bugbot — correctly notes low risk and no runtime change; agrees on scope. I disagree with the implicit assumption that the ariaLabelledBy comment accurately documents accessibility behavior — see blocking finding.
• Copilot — reviewed 2/2 files, generated no comments; consistent with my assessment aside from the ariaLabelledBy documentation gap.

Prior review

Copilot posted a COMMENTED overview on 2026-09-11 with no inline findings. No prior formal approval or changes-requested review to track.

Final decision

🔴 Needs changes before approval — please correct the ariaLabelledBy comment (or wire up a channel PrimeNG actually consumes, e.g. pt.root['aria-labelledby']) before merge.

[dealako]

Review summary

🔴 Needs changes before approval

Solid follow-up documentation for the headless CCLA hand-off dialog. The showHeader and contentStyle comments and the spec rename look good.

Blocking (1): The ariaLabelledBy comment at org-easycla-detail.component.ts:403-405 describes behavior PrimeNG 20.4.0 does not implement — DynamicDialogConfig.ariaLabelledBy is declared but never bound in DynamicDialog's <p-dialog> template, so the config value is inert. Because this PR only adds comments, merging would entrench a false accessibility rationale at the call site.

See inline comment for proof and fix options.

Bots: Agree with Cursor/Copilot on low runtime risk; disagree that the ariaLabelledBy comment is accurate.

[dealako]

[blocking] Correct the ariaLabelledBy comment — config value is inert in PrimeNG 20.4.0

Issue: The comment claims that with showHeader:false PrimeNG "emits no generated title" and that setting ariaLabelledBy points the role="dialog" at the body's <h2>. Neither is true for the pinned dependency (primeng@20.4.0).

Proof: In PrimeNG 20.4.0, DynamicDialogConfig.ariaLabelledBy is documented on the config type but DynamicDialog's template forwards header, showHeader, contentStyle, etc. to <p-dialog> — there is no [ariaLabelledBy] binding, so ddconfig.ariaLabelledBy is never read. Dialog has no ariaLabelledBy @Input(); it computes its own ariaLabelledBy field via getAriaLabelledBy() (header !== null ? uuid + '_header' : null). With no header passed, undefined !== null is true, so a generated pn_id_N_header id can be bound via [attr.aria-labelledby] on the dialog root while the <span [id]="ariaLabelledBy"> lives inside the titlebar gated by *ngIf="showHeader" and is not rendered. The hand-off <h2 id="org-easycla-sign-handoff-heading"> is never referenced. Locally, org-easycla-detail.component.spec.ts:398 only asserts the mocked open() config echo — it cannot detect PrimeNG ignoring the property. The same pattern exists at lens-switcher.component.ts:143-145.

Why it matters: This is the CCLA signing hand-off modal (non-dismissible while preparing). Screen readers may announce an unnamed dialog because aria-labelledby references a non-existent element. This PR's sole deliverable is these comments — merging cements a false account and removes the prompt to fix accessibility.

Fix: Wire naming through a channel DynamicDialog actually forwards, e.g. pt: { root: { 'aria-labelledby': OrgEasyclaSignHandoffComponent.headingId } } on the open() config (confirm the rendered attribute resolves to the <h2>), then rewrite the comment to match. If keeping the diff comment-only, the comment must state that DynamicDialogConfig.ariaLabelledBy is inert in PrimeNG 20.4.0 rather than claiming it names the dialog.