Remove NACK Consumer k8s resource and update to LastPerSubject delivery#15
Merged
Remove NACK Consumer k8s resource and update to LastPerSubject delivery#15
Conversation
- Remove k8s/helm Consumer resource template and configuration - Update main.go consumer creation to use LastPerSubject deliver policy - Upgrade helm chart version to 0.3.4 - Consumer will now be created by service on startup when missing 🤖 Generated with [GitHub Copilot](https://github.com/features/copilot) (via Zed) Signed-off-by: Eric Searcy <eric@linuxfoundation.org>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates NATS consumer management from Kubernetes/Helm declarative resources to programmatic creation in application code, enabling the use of DeliverLastPerSubjectPolicy for more efficient KV bucket message processing.
- Removes Kubernetes-managed NATS consumer resource and transitions to application-managed consumer creation
- Updates consumer delivery policy from
DeliverAllPolicytoDeliverLastPerSubjectPolicyfor improved efficiency with KV workloads - Bumps Helm chart version to 0.3.4
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| v1-sync-helper/main.go | Updated consumer configuration to use DeliverLastPerSubjectPolicy and removed commented code |
| charts/lfx-v1-sync-helper/values.yaml | Removed nats.consumer configuration section (lines 103-130) |
| charts/lfx-v1-sync-helper/templates/nats-consumer.yaml | Deleted entire Kubernetes Consumer resource template |
| charts/lfx-v1-sync-helper/Chart.yaml | Bumped chart version from 0.3.3 to 0.3.4 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Helps `nats consumer ls` fit in a smaller terminal window without truncating stats. Signed-off-by: Eric Searcy <eric@linuxfoundation.org>
emsearcy
force-pushed
the
feature/update-nack-consumer-config
branch
from
7e4b82a to
0e115c3
Compare
Contributor
Author
|
force-pushed due to missing signoff |
jordane
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses LFXV2-868: Remove the NACK Consumer configuration from k8s/helm and let it be created by the service on startup when missing so that we can create it in LastPerSubject mode.
Changes Made
charts/lfx-v1-sync-helper/templates/nats-consumer.yamlLastPerSubjectPolicyinstead ofDeliverAllPolicyvalues.yamlby removing the entirenats.consumersectionTechnical Details
CreateOrUpdateConsumer()DeliverAllPolicytoDeliverLastPerSubjectPolicyto improve message delivery efficiencyTesting
Post-Merge Steps
After merging and releasing:
Related to: LFXV2-868