Conversation
…pty date Signed-off-by: Andres Tobon <andrest2455@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes critical issues with meeting data synchronization by addressing date parsing errors for optional timestamp fields and ensuring proper ID population for recording data. The changes prevent indexing failures and improve data transformation reliability between v1 and v2 systems.
- Fixed date parsing logic to handle empty/missing
CreatedAtandModifiedAttimestamps in participant conversion functions - Corrected indexer message payloads to send full typed objects instead of intermediate maps
- Added v2 system ID field population and default values for recording access settings
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
v1-sync-helper/handlers_meetings.go |
Refactored timestamp parsing to check for non-empty strings before parsing; updated indexer to send typed objects; added recording ID mapping and access defaults |
v1-sync-helper/models_meetings.go |
Added ID field to PastMeetingRecordingInput struct for v2 system compatibility |
charts/lfx-v1-sync-helper/Chart.yaml |
Bumped chart version from 0.3.4 to 0.3.5 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Fix indexer message to send meeting/pastMeeting struct instead of raw v1Data - Add ID field to PastMeetingRecordingInput to match v2 system expectations - Add logic to detect transcript files and set transcript fields accordingly - Set default recording access to meeting_hosts when not specified Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Andres Tobon <andrest2455@gmail.com>
andrest50
force-pushed
the
andrest50/fix-date-parsing
branch
from
4e3d8cd to
2c274f0
Compare
emsearcy
reviewed
Dec 4, 2025
emsearcy
reviewed
Dec 4, 2025
emsearcy
approved these changes
Dec 4, 2025
emsearcy
added a commit
that referenced
this pull request
Dec 4, 2025
Change JoinTime from time.Time to *time.Time with omitempty tag to allow for cases where join time might not be available or recorded. This change was missed in PR #16. 🤖 Generated with GitHub Copilot (https://github.com/features/copilot) (via Zed) Signed-off-by: Eric Searcy <eric@linuxfoundation.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily improves the reliability and correctness of meeting data synchronization and transformation logic, especially around handling optional timestamps and session data for past meeting participants. It also introduces enhancements for recording data mapping and updates the chart version.
Meeting participant transformation improvements
convertInviteeToV2ParticipantandconvertAttendeeToV2Participantto parseCreatedAtandModifiedAttimestamps only if they are present, preventing errors from empty or missing fields. [1] [2] [3] [4]convertAttendeeToV2Participantto handle optionalJoinTimeandLeaveTimefields, ensuring robust parsing and assignment of session times.Indexer message payload consistency
Past meeting recording mapping enhancements
IDfield from the v1 recording partition key, set default recording access to "meeting_hosts" if not specified, and auto-enable transcript features if transcript files are present. [1] [2]Chart version update
lfx-v1-sync-helperfrom0.3.4to0.3.5.